Fix typechecking errors that appeared under mypy release 1.16 #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12e1773 to
3cea017
Compare
d73cc0a to
d88f9cd
Compare
The following errors are now in GH Actions at HEAD:
absl/flags/_helpers.py:108: error: Argument 1 to "get" of "dict" has incompatible type "Any | None"; expected "str" [arg-type]
absl/flags/_helpers.py:111: error: Argument 2 to "_ModuleObjectAndName" has incompatible type "str | Any | None"; expected "str" [arg-type]
absl/testing/absltest.py:2745: error: Incompatible types in assignment (expression has type "str", variable has type "_T") [assignment]
To resolve these errors more constructively, I also change the interface of `_ModuleObjectAndName`: instead of a tuple of Optionals, it's an Optional tuple now. The whole file is private, so changing the API is OK.
PiperOrigin-RevId: 766637390
d88f9cd to
55c8f4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typechecking errors that appeared under mypy release 1.16
The following errors are now in GH Actions at HEAD:
To resolve these errors more constructively, I also change the interface of
_ModuleObjectAndName: instead of a tuple of Optionals, it's an Optional tuple now. The whole file is private, so changing the API is OK.