fix compilation with AppleClang #1819
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekmauro
pushed a commit
to derekmauro/abseil-cpp
that referenced
this pull request
Feb 3, 2025
Imported from GitHub PR abseil#1819 Fix the following error: absl/random/internal/randen_detect.cc:123:12: error: no member named 'nullopt' in namespace 'std'; did you mean 'absl::nullopt'? 123 | return std::nullopt; | ^~~~~~~~~~~~ | absl::nullopt absl/types/optional.h:86:43: note: 'absl::nullopt' declared here 86 | ABSL_INTERNAL_INLINE_CONSTEXPR(nullopt_t, nullopt, | ^ Merge b9a2d39 into 7253ff8 Merging this change closes abseil#1819 COPYBARA_INTEGRATE_REVIEW=abseil#1819 from clementperon:master b9a2d39 PiperOrigin-RevId: 722599523 Change-Id: Ie66cbf9daf3b115668194da8b74acd6a43e12a03
derekmauro
added a commit
that referenced
this pull request
Feb 3, 2025
Imported from GitHub PR #1819 Fix the following error: absl/random/internal/randen_detect.cc:123:12: error: no member named 'nullopt' in namespace 'std'; did you mean 'absl::nullopt'? 123 | return std::nullopt; | ^~~~~~~~~~~~ | absl::nullopt absl/types/optional.h:86:43: note: 'absl::nullopt' declared here 86 | ABSL_INTERNAL_INLINE_CONSTEXPR(nullopt_t, nullopt, | ^ Merge b9a2d39 into 7253ff8 Merging this change closes #1819 COPYBARA_INTEGRATE_REVIEW=#1819 from clementperon:master b9a2d39 PiperOrigin-RevId: 722599523 Change-Id: Ie66cbf9daf3b115668194da8b74acd6a43e12a03 Co-authored-by: Clément Péron <peron.clem@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the following error:
absl/random/internal/randen_detect.cc:123:12: error: no member named 'nullopt' in namespace 'std'; did you mean 'absl::nullopt'?
123 | return std::nullopt;
| ^~~~~~~~~~~~
| absl::nullopt
absl/types/optional.h:86:43: note: 'absl::nullopt' declared here
86 | ABSL_INTERNAL_INLINE_CONSTEXPR(nullopt_t, nullopt,
| ^