CMake: Install TESTONLY libraries and their dependencies #1442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
they are built abseil#1407 PiperOrigin-RevId: 513684529 Change-Id: Ie0a164eea32becfef8f8e4a112aee158fd93dd7e
surfacepatterns
pushed a commit
to surfacepatterns/fedora-rpm-abseil-cpp
that referenced
this pull request
Aug 2, 2024
- Explicitly list all installed shared libraries See: abseil/abseil-cpp#1442
crupest
pushed a commit
to crupest/abseil-cpp
that referenced
this pull request
Feb 9, 2025
Abseil 20230125.3 exposes libraries that were formerly internal (“test-only”) so that other packages’ unit tests can refer to them [1]. Some of the new libraries depend on Google Mock, which Debian only ships as a static library; as a result, the new libraries can only be shipped statically as well. Historically, however, Abseil’s Debian packaging has linked Abseil’s unit tests dynamically to improve build speed. (Google Mock was built as a one-off shared library during this process, but it was only ever used in unit tests and was never shipped to users.) Static Abseil builds were unaware that Google Mock existed, which prevented sbuild from building the new libraries [2]. To rectify the situation, change Abseil’s Debian packaging to link Abseil unit tests statically and to ship the new libraries as static archives. Also make libabsl-dev recommend libgmock-dev, since the new libraries are useless without a corresponding Google Mock build. [1] abseil#1442 [2] https://bugs.debian.org/1034908
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick #1407 for next release.
This will address downstream Protobuf issues such as protocolbuffers/protobuf#12201