-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Closed
Description
Describe the issue
It wasn't obvious to me before attempting to update to the newest release that it's broken without 35e8e3f. Can you please create a new 20230125.1 release that includes this change? Thank you!
Steps to reproduce the problem
Build the Cord library with -fsanitize=address. It fails to compile with:
absl/strings/internal/cord_internal.h: In copy constructor ‘constexpr absl::lts_20230125::cord_internal::InlineData::InlineData(const absl::lts_20230125::cord_internal::InlineData&)’:
absl/strings/internal/cord_internal.h:821:39: error: call to non-‘constexpr’ function ‘absl::lts_20230125::cord_internal::InlineData::Rep absl::lts_20230125::cord_internal::InlineData::Rep::SanitizerSafeCopy() const’
821 | : rep_(rhs.rep_.SanitizerSafeCopy()) {
| ^
absl/strings/internal/cord_internal.h:771:9: note: ‘absl::lts_20230125::cord_internal::InlineData::Rep absl::lts_20230125::cord_internal::InlineData::Rep::SanitizerSafeCopy() const’ declared here
771 | Rep SanitizerSafeCopy() const {
| ^~~~~~~~~~~~~~~~~
What version of Abseil are you using?
20230125.0
What operating system and version are you using?
Linux/CentOS 7
What compiler and version are you using?
GCC 10/Clang 15
What build system are you using?
Either Bazel 6 or CMake 3
Additional context
I'm excited for the new features like logging and crc32 in the 20230125 release :) Thanks for continuing to make improvements to Abseil!
Metadata
Metadata
Assignees
Labels
No labels