Data collection #23343
Data collection #23343
Conversation
|
|
||
| public static class ActivityPropertyNames | ||
| { | ||
| public const string SessionId = "SessionId"; |
| @@ -184,5 +184,6 @@ | |||
| <PackageVersion Include="coverlet.collector" Version="6.0.4" /> | |||
| <PackageVersion Include="ConfigureAwait.Fody" Version="3.3.2" /> | |||
| <PackageVersion Include="Fody" Version="6.9.2" /> | |||
| <PackageVersion Include="System.Management" Version="9.0.1"/> | |||
There was a problem hiding this comment.
Other lines uses space but this line uses tab. We can change it to spaces
| } | ||
| catch (System.Exception ex) | ||
| { | ||
| System.Console.WriteLine("WARNING ABP-LIC-0025! Contact to license@abp.io with the below information" + |
There was a problem hiding this comment.
I think we can remove this log
| System.Environment.NewLine + | ||
| "* Error: " + ex.ToString()); | ||
|
|
||
| return "95929008-b147-454a-8737-efed71fa2241"; |
There was a problem hiding this comment.
If this is not required, we can return empty string here
| { | ||
| var outputBuilder = new StringBuilder(); | ||
|
|
||
| var processStartInfo = new ProcessStartInfo |
There was a problem hiding this comment.
It would be better to use CmdHelper here. There is a bug/problem running commands in MAC computers, so fixing it in CmdHelper will prevent future problems about data collection.
|
|
||
| using (var process = new System.Diagnostics.Process()) | ||
| { | ||
| process.StartInfo = new System.Diagnostics.ProcessStartInfo(GetFileName()) |
There was a problem hiding this comment.
It would be better to use CmdHelper here.
| try | ||
| { | ||
| using var process = new Process(); | ||
| process.StartInfo = new ProcessStartInfo |
There was a problem hiding this comment.
It would be better to use CmdHelper here
|
|
||
| var process = new Process | ||
| { | ||
| StartInfo = new ProcessStartInfo |
There was a problem hiding this comment.
It would be better to use CmdHelper here
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rel-9.3 #23343 +/- ##
==========================================
Coverage ? 51.44%
==========================================
Files ? 3257
Lines ? 105450
Branches ? 8065
==========================================
Hits ? 54246
Misses ? 49555
Partials ? 1649 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.