[feat-930] added added date sorting for maps/songs #931
Conversation
|
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
|
|
||
| // Create the metadata then return it to the user | ||
| const metadata: BsmLocalMapMetadata = { | ||
| addedDate: dateFormat(new Date(), "yyyy-mm-dd'T'hh:MM:ss.l"), |
There was a problem hiding this comment.
Bug: Bug
The addedDate in metadata.json uses a 12-hour format (hh) without AM/PM indicators. This results in ambiguous timestamps, making it impossible to distinguish between AM and PM times, and prevents accurate chronological sorting of maps.
There was a problem hiding this comment.
@Zagrios Yeah, seems to be like it. Let me check the existing formats as well, if this is a problem as well.
Just for reference https://www.npmjs.com/package/dateformat#mask-options
|
|
Thanks @silentrald ❤️ |
Closes #930
Added a way to sort maps depending on when they were added on the system.
Maintainer Notes:
Current label:
Added Date(there might be better label for this)Note
Introduce
added-datesorting for local maps by persistingmetadata.json(withaddedDate) and update translations accordingly.metadata.jsonwithaddedDateon load/import inLocalMapsManagerService; attachmetadatatoBsmLocalMap.added-dateinmapSorterto sort bymetadata.addedDate.added-datelabel toassets/jsons/translations/*.jsonunder maps sort options.Written by Cursor Bugbot for commit 02ed95e. This will update automatically on new commits. Configure here.