metallum: replace deprecated 'remove_expired_responses' #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 9, 2025 06:17
Replace the (according to the code [1]) deprecated 'remove_expired_responses' call, with 'delete' - as suggested in the deprecation comment. Link: https://github.com/requests-cache/requests-cache/blob/v1.2.1/requests_cache/backends/base.py#L251 Signed-off-by: Johannes <you@example.com>
Not all artists/bands have their "Similar Artists" tab populated. In such cases metalarchives returns a specific string with an url. Trouble is that link is picked up by the current parsing code, leading to errors when accessing the different properties usually present in a Band object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the (according to the code [1]) deprecated 'remove_expired_responses' call, with 'delete' - as suggested in the deprecation comment.
Link: https://github.com/requests-cache/requests-cache/blob/v1.2.1/requests_cache/backends/base.py#L251
Closes #
📑 Description
✅ Checks
ℹ Additional Information