chore(deps): bun.lockへの移行とESLint設定の更新 #1173
Conversation
Migrate from binary lockfile format (bun.lockb) to text-based lockfile (bun.lock) for better version control. Add proper ESLint plugin configurations for testing-library and storybook with specific rule enforcement. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Warning Rate limit exceeded@YasushiKobayashi has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 32 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughAdds ESLint testing-library and storybook plugins; upgrades Storybook/related dependencies and migrates Storybook config and stories to ESM/Next.js package; introduces a GitHub Actions step to wait for the server; and updates .gitignore. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant GH as GitHub Actions
participant Runner as Workflow Runner
participant Server as Local Dev Server (localhost:3000)
Note over GH,Runner: e2e job start
GH->>Runner: start server (background)
Runner->>Server: HTTP GET / (loop)
alt server responds within 60s
Server-->>Runner: 200 OK
Runner->>GH: proceed to run e2e tests
else timeout or no response
Runner-->>GH: fail job (server not ready)
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @YasushiKobayashi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! このプルリクエストは、開発環境の保守性と品質を向上させることを目的としています。Bunのロックファイルをテキスト形式に移行することで、変更履歴の追跡を容易にし、testing-libraryとStorybookに特化したESLintルールを導入することで、コードの一貫性と品質を確保します。また、Storybookの依存関係と設定を最新化し、開発ワークフローを最適化します。 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
このプルリクエストは、bun.lockへの移行、ESLint設定の更新、および依存関係の更新を行うものです。ESLintにtesting-libraryとstorybookのプラグインを追加する対応は良いと思いますが、設定にいくつか問題が見られます。特に、package.jsonで指定されている依存関係のバージョンの多くが存在しないため、インストールが失敗する可能性が非常に高いです。また、Storybookの設定ファイルから重要なアドオンが削除されており、インタラクションテストが動作しなくなると思われます。これらの点について、具体的な修正案をコメントしましたのでご確認ください。
| files: ['**/*.spec.{ts,tsx}', '**/*.test.{ts,tsx}'], | ||
| plugins: { 'testing-library': testingLibraryPlugin }, | ||
| rules: { | ||
| 'testing-library/await-async-events': 2, | ||
| 'testing-library/await-async-queries': 2, | ||
| 'testing-library/await-async-utils': 2, | ||
| 'testing-library/no-await-sync-events': 2, | ||
| 'testing-library/no-await-sync-queries': 2, | ||
| }, |
There was a problem hiding this comment.
このtesting-library用の設定は素晴らしいですが、現在の設定では意図した通りに動作しない可能性があります。
ファイルの先頭にあるignores設定で、テストファイル（src/**/*.spec.{ts,tsx}, src/**/*.test.{ts,tsx}）が除外されているため、このルールブロックが適用されません。
この設定を有効にするには、ignores配列から該当のパターンを削除する修正が別途必要になります。
サーバーの起動完了を待ってからe2eテストを実行するように修正 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/js_test.yml (1)
91-93: Well-placed server readiness check with sound implementation.The "wait for server" step properly ensures the dev server is ready before running E2E tests, preventing race conditions. The polling mechanism using
curl -fwith retry loop and 60-second timeout is a solid approach that's standard in CI workflows.Optional improvement: Consider polling a dedicated health endpoint if available. The current approach polls any endpoint and accepts any HTTP response. If the dev server exposes a health check endpoint (e.g.,
/api/health), polling that could provide stronger confidence that the server is fully initialized:- run: | - timeout 60 bash -c 'until curl -f http://localhost:3000 > /dev/null 2>&1; do sleep 1; done' + run: | + timeout 60 bash -c 'until curl -f http://localhost:3000/api/health > /dev/null 2>&1; do sleep 1; done'Only apply this if such an endpoint exists and is appropriate for your Next.js sample application.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/js_test.yml(1 hunks).gitignore(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
.github/workflows/**
📄 CodeRabbit inference engine (.cursor/rules/all.mdc)
Run automated tests via GitHub Actions workflows
Files:
.github/workflows/js_test.yml
.github/workflows/*.y?(a)ml
📄 CodeRabbit inference engine (CLAUDE.md)
Configure GitHub Actions to run lint, type-check, unit tests, E2E tests, upload coverage to Codecov, and run Chromatic/Launchable on push to master and PRs
Files:
.github/workflows/js_test.yml
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
Repo: YasushiKobayashi/samples PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-21T20:10:03.369Z
Learning: Applies to .github/workflows/*.y?(a)ml : Configure GitHub Actions to run lint, type-check, unit tests, E2E tests, upload coverage to Codecov, and run Chromatic/Launchable on push to master and PRs
📚 Learning: 2025-09-21T20:10:03.369Z
Learnt from: CR
Repo: YasushiKobayashi/samples PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-21T20:10:03.369Z
Learning: Applies to src/playwright-sample/** : Keep Playwright E2E tests within the src/playwright-sample workspace and execute them from there
Applied to files:
.github/workflows/js_test.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: e2e
🔇 Additional comments (1)
.gitignore (1)
60-61: LGTM!Both additions are well-motivated and aligned with the PR objectives:
- Line 60:
settings.local.jsonis a standard pattern for local configuration files that should not be committed.- Line 61:
test-report.junit.xmlaligns with the test tooling changes (eslint-plugin-testing-library and related test setups) mentioned in the PR, and complements the existing test-report ignores at lines 46 and 59.No issues identified.
vitest-ciコマンドにdefaultレポーターを追加し、 失敗したテストの詳細がコンソールに表示されるように修正 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Storybook portable storiesのcomposeStoriesをVitestで使用すると Next.jsモジュールの解決に問題が発生するため、 テストを直接コンポーネントをインポートする方式に書き換え 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
@testing-library/user-eventが依存関係に含まれていないため、 @testing-library/reactのfireEventを使用するように変更 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Storybook 10の型定義を正しく解決するため、 tsconfig.jsonのmoduleResolutionをbundlerに設定 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
概要
変更内容
bun.lockbをbun.lock(テキスト形式) に置き換えテスト計画
🤖 Generated with Claude Code
Summary by CodeRabbit