feat: Prompt to save on unsaved changes in editor #1334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds isDirty flag to track unsaved changes in the editor. Prompts the user to save changes before unmounting if there are unsaved edits. Refactors usage of req to originalReq for state synchronization and saving.
Owner
|
looks like a solid change! will test and merge if all looks good. |
Owner
|
ah uses the browser's alert to do the change. That needs cleaning up, but i can do that in a dev branch. |
Contributor
Author
|
I can change to notifications instead of browser API. Is there a package already being used for notifications? @gtsteffaniak |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR prevents accidental data loss in the file editor by introducing a confirmation prompt when a user tries to exit with unsaved changes. Currently, a user can edit a file and close the tab or navigate away without any warning, causing all modifications to be permanently lost.
This change implements the behavior suggested in issue #1241.
Now, the editor tracks if the content has been modified. If a user with unsaved changes attempts to leave the page, a confirmation dialog will appear, asking if they want to save their work before exiting.
Additional Details
Adds isDirty flag to track unsaved changes in the editor. Prompts the user to save changes before unmounting if there are unsaved edits. Refactors usage of req to originalReq for state synchronization and saving.