这是indexloc提供的服务，不要输入任何密码
Skip to content

Feat: Enabled plyr video player to rotate when entering full screen #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2025
Merged

Feat: Enabled plyr video player to rotate when entering full screen #1251

merged 1 commit into from
Sep 19, 2025

Conversation

@xMarkos
Copy link
Contributor

@xMarkos xMarkos commented Sep 19, 2025

Description
Feat: Enabled plyr video player to rotate when entering full screen

  • this makes it much more convenient to watch landscape videos when device is locked in portrait mode (or vice versa)
  • it uses the device's rotation sensor
  • it gets activated when the plyr video player enters full screen mode
  • it works when the device's rotation is currently locked

According to the contributing guide, A PR should contain:

  • A clear description of why it was opened.
  • A short title that best describes the change.
  • Must pass unit and integration tests, which can be run checked locally prior to opening a PR.
  • Any additional details for functionality not covered by tests.

Additional Details

@xMarkos
Enabled plyr video player to rotate when entering full screen
049389c 
- this makes it much more convenient to watch landscape videos when device is locked in portrait mode (or vice versa)
- it uses the device's rotation sensor
- it gets activated when the plyr video player enters full screen mode
- it works when the device's rotation is currently locked
@xMarkos
Copy link
Contributor Author

xMarkos commented Sep 19, 2025

Hi @gtsteffaniak,

Since the recent change that added plyr.io media player (which is a very welcomed change), we found it inconvenient to play landscape videos on phones, as we would need to unlock the device orientation each time before entering video full screen.
This simple PR forces the device to act as if it was unlocked when it enters the video full screen mode.

I have tested this manually with my android device and my chrome browser on Windows, however, I don't have other device types to test this on. I am quite confident that other devices should work though.

As this is a feature I would really like to see incorporated, I really want it to make it into your release.
Please let me know if you have any questions or things you would like me to change.

M.

@gtsteffaniak gtsteffaniak changed the base branch from main to dev/v0.8.7 September 19, 2025 15:19
@gtsteffaniak
Copy link
Owner

gtsteffaniak commented Sep 19, 2025

Thanks so much @xMarkos ! I don't have tests that would cover this so I will merge to a dev branch and quickly test it there as well.

If all is well, it will show up in 0.8.7 when released!

@gtsteffaniak gtsteffaniak merged commit e0e464c into gtsteffaniak:dev/v0.8.7 Sep 19, 2025
14 checks passed
@Kurami32
Copy link
Collaborator

Kurami32 commented Sep 19, 2025 •
edited
Loading

I can confirm that is working. I tested this :D
But only on chromium, on firefox/gecko this seems that is overrided with the browser defaults.

@xMarkos xMarkos deleted the feature-plyr-fullscreen-rotation branch September 19, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xMarkos @gtsteffaniak @Kurami32