Fix directories empty issue when disableIndexing is true #1249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I don't think this is the solution, the checkSkip function should know all the rules and not need this other condition, you can see the tests fail on some of these exclusion rule expectations. If you notice an issue, id recommend first open an issue to discuss the solution. |
invert condition
Owner
|
This looks like it was on the right track, but the condition needed to be inverted, so it defaults to always check but can be overriden as part of the actionConfig. |
Owner
|
I will merge, then add a test to make sure this doesn't break again |
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #1248, repro steps:
disableIndexing: trueCause
indexingFiles.go,checkSkipparameter of methodGetDirInfois removed.idx.shouldSkipalways returntruewhenidx.Config.DisableIndexingistrueindex.GetFsDirInfo(opts.Path)is called fromFileInfoFasterwhenindex.Config.DisableIndexingistrue.The issue raises:
Previous:
index.GetFsDirInfo(opts.Path)callsGetDirInfowithcheckSkipasfalsesoGetDirInfowill NOT skip file listing even whenshouldSkipistrueNow:
GetDirInfowill ALWAYS skip file listing whenshouldSkipistrueFixes:
Add
checkSkipas a parameter toindex.GetFsDirInfo(opts.Path)so it bahaves as before.Tests:
Tested locally with a few scenarios.