这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@devisnik
Copy link
Contributor

@devisnik devisnik commented May 5, 2020

We've released GE plugin 3.3

@devisnik devisnik added this to the 6.4 milestone May 5, 2020
@devisnik devisnik requested review from rieske and wolfs May 5, 2020 11:42
@devisnik devisnik self-assigned this May 5, 2020
Copy link
Member

@wolfs wolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I suggest to remove the checksum of the rc from the metadata file, tough.

</artifact>
</component>
<component group="com.gradle" name="gradle-enterprise-gradle-plugin" version="3.3-rc-1">
<artifact name="gradle-enterprise-gradle-plugin-3.3-rc-1.jar">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the entries for rcs from this file and only keep the final versions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Done

Copy link
Member

@wolfs wolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@big-guy big-guy merged commit 42f7c3d into release May 5, 2020
@wolfs wolfs deleted the devisnik/ge-plugin-3-3 branch June 18, 2021 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants