Add gpu texture format supported by copyImageBitmapToTexture destination #849
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Kangz @kainino0x @austinEng @litherum PTAL! |
JusSn
reviewed
Jun 8, 2020
JusSn
reviewed
Jun 8, 2020
This patch added gpu texture format supported by copyImageBitmapToTexture. If developer provided other format textures, copyImageBitmapToTexture doesn't do color conversion for it and report type error.
Co-authored-by: Justin Fan <jussnf@gmail.com>
Contributor
Author
|
@JusSn Thanks for reviewing, Updated this as your suggestion. |
kvark
approved these changes
Jun 15, 2020
Contributor
kvark
left a comment
There was a problem hiding this comment.
I don't know how hard it would be to support those. Will reserve the right to come back to this when we are actually implementing this :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch added gpu texture format supported by copyImageBitmapToTexture.
If developer provided other format textures, copyImageBitmapToTexture doesn't
do color conversion for it and report type error.
Preview | Diff