-
Notifications
You must be signed in to change notification settings - Fork 329
Query API: Add Occlusion Query #656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add the definition of Occlusion Query and its requirements. * Add precise occlusion query as extension. * Define QuerySet, QuerySetDescriptor and QueryType. * Add query set in render pass descriptor for occlusion query. * Add begin/endOcclusionQuery on render pass encoder. * Resolve query result from query set on command encoder. * Add a new buffer usage for resolving query result.
98f4c52
to
2092f73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolution from meeting: we'd like to merge with the attached changes, then work on those things as followups.
Co-Authored-By: Kai Ninomiya <kainino1@gmail.com>
Co-Authored-By: Kai Ninomiya <kainino1@gmail.com>
Co-Authored-By: Kai Ninomiya <kainino1@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the iteration I think this matches what the group resolved too so I'll go ahead and merge it.
* Query API: Add Occlusion Query Add the definition of Occlusion Query and its requirements. * Define QuerySet, QuerySetDescriptor and QueryType. * Add query set in render pass descriptor for occlusion query. * Add begin/endOcclusionQuery on render pass encoder. * Resolve query result from query set on command encoder. * Add a new buffer usage for resolving query result.
* Query API: Add Occlusion Query Add the definition of Occlusion Query and its requirements. * Define QuerySet, QuerySetDescriptor and QueryType. * Add query set in render pass descriptor for occlusion query. * Add begin/endOcclusionQuery on render pass encoder. * Resolve query result from query set on command encoder. * Add a new buffer usage for resolving query result.
Add the definition of Occlusion Query and its requirements according to #614:
Preview | Diff