Query API: Add Occlusion Query #656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the definition of Occlusion Query and its requirements. * Add precise occlusion query as extension. * Define QuerySet, QuerySetDescriptor and QueryType. * Add query set in render pass descriptor for occlusion query. * Add begin/endOcclusionQuery on render pass encoder. * Resolve query result from query set on command encoder. * Add a new buffer usage for resolving query result.
98f4c52 to
2092f73
Compare
Closed
Kangz
approved these changes
Mar 30, 2020
litherum
approved these changes
Mar 30, 2020
kainino0x
approved these changes
Mar 30, 2020
Contributor
kainino0x
left a comment
There was a problem hiding this comment.
Resolution from meeting: we'd like to merge with the attached changes, then work on those things as followups.
Co-Authored-By: Kai Ninomiya <kainino1@gmail.com>
Co-Authored-By: Kai Ninomiya <kainino1@gmail.com>
Co-Authored-By: Kai Ninomiya <kainino1@gmail.com>
Kangz
approved these changes
Mar 31, 2020
Contributor
Kangz
left a comment
There was a problem hiding this comment.
Thanks for the iteration I think this matches what the group resolved too so I'll go ahead and merge it.
JusSn
pushed a commit
to JusSn/gpuweb
that referenced
this pull request
Jun 8, 2020
* Query API: Add Occlusion Query Add the definition of Occlusion Query and its requirements. * Define QuerySet, QuerySetDescriptor and QueryType. * Add query set in render pass descriptor for occlusion query. * Add begin/endOcclusionQuery on render pass encoder. * Resolve query result from query set on command encoder. * Add a new buffer usage for resolving query result.
JusSn
pushed a commit
to JusSn/gpuweb
that referenced
this pull request
Jun 8, 2020
* Query API: Add Occlusion Query Add the definition of Occlusion Query and its requirements. * Define QuerySet, QuerySetDescriptor and QueryType. * Add query set in render pass descriptor for occlusion query. * Add begin/endOcclusionQuery on render pass encoder. * Resolve query result from query set on command encoder. * Add a new buffer usage for resolving query result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the definition of Occlusion Query and its requirements according to #614:
Preview | Diff