这是indexloc提供的服务,不要输入任何密码
Skip to content

Query API: Add Occlusion Query #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 31, 2020
Merged

Conversation

haoxli
Copy link
Contributor

@haoxli haoxli commented Mar 30, 2020

Add the definition of Occlusion Query and its requirements according to #614:

  • Define QuerySet, QuerySetDescriptor and QueryType.
  • Add query set in render pass descriptor for occlusion query.
  • Add begin/endOcclusionQuery on render pass encoder.
  • Resolve query result from query set on command encoder.
  • Add a new buffer usage for resolving query result.

Preview | Diff

Add the definition of Occlusion Query and its requirements.
* Add precise occlusion query as extension.
* Define QuerySet, QuerySetDescriptor and QueryType.
* Add query set in render pass descriptor for occlusion query.
* Add begin/endOcclusionQuery on render pass encoder.
* Resolve query result from query set on command encoder.
* Add a new buffer usage for resolving query result.
@haoxli haoxli force-pushed the query-api-occlusion branch from 98f4c52 to 2092f73 Compare March 30, 2020 06:53
@haoxli haoxli mentioned this pull request Mar 30, 2020
Copy link
Contributor

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolution from meeting: we'd like to merge with the attached changes, then work on those things as followups.

haoxli and others added 3 commits March 31, 2020 10:08
Co-Authored-By: Kai Ninomiya <kainino1@gmail.com>
Co-Authored-By: Kai Ninomiya <kainino1@gmail.com>
Co-Authored-By: Kai Ninomiya <kainino1@gmail.com>
Copy link
Contributor

@Kangz Kangz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the iteration I think this matches what the group resolved too so I'll go ahead and merge it.

@Kangz Kangz merged commit 0245441 into gpuweb:master Mar 31, 2020
JusSn pushed a commit to JusSn/gpuweb that referenced this pull request Jun 8, 2020
* Query API: Add Occlusion Query

Add the definition of Occlusion Query and its requirements.
* Define QuerySet, QuerySetDescriptor and QueryType.
* Add query set in render pass descriptor for occlusion query.
* Add begin/endOcclusionQuery on render pass encoder.
* Resolve query result from query set on command encoder.
* Add a new buffer usage for resolving query result.
JusSn pushed a commit to JusSn/gpuweb that referenced this pull request Jun 8, 2020
* Query API: Add Occlusion Query

Add the definition of Occlusion Query and its requirements.
* Define QuerySet, QuerySetDescriptor and QueryType.
* Add query set in render pass descriptor for occlusion query.
* Add begin/endOcclusionQuery on render pass encoder.
* Resolve query result from query set on command encoder.
* Add a new buffer usage for resolving query result.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants