Use FrozenArray<> instead of sequence<> for extensions attribute.
#545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sequences must not be used as the type of an attribute or constant[1]. [1] https://heycam.github.io/webidl/#idl-sequence
kainino0x
approved these changes
Jan 26, 2020
Contributor
kainino0x
left a comment
There was a problem hiding this comment.
Right you are! Thanks again for finding my mistakes!
(I had been wondering, since sequence is an input type, whether it was also a valid output type, but I failed to find that bit in the spec...)
pull bot
pushed a commit
to FreddyZeng/chromium
that referenced
this pull request
Feb 6, 2020
Related spec changes: gpuweb/gpuweb#518 gpuweb/gpuweb#545 Bug: 852089 Change-Id: I462caa2a94664a19f518a1e6813328acc68f77bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021564 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#738858}
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
* Expand operation tests for copyToTexture,ImageBitmap
- Add all valid {dstColorFormat} for `from_canvas` test
- Add {orientation} config for `from_canvas` test
- Add generateImagePixels() helper function to reduce duplicate code
- Verify `from_canvas` tests can cover gpu uploading path.
* Address comments to fix format issues
* Address comments
* Refactor `generatePixel` with Kai's suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sequences must not be used as the type of an attribute or constant[1].
[1] https://heycam.github.io/webidl/#idl-sequence
Preview | Diff