Move GPUAdapter isFallbackAdapter attribute to GPUAdapterInfo #5099
Conversation
|
Previews, as seen when this build job started (1f640d2): |
|
We did although we had no representation from WebKit. @mwyrzykowski does this look good to you? Chromium will try to move the boolean as well but if we fail to do it without breaking pages, we'll also keep the previous one in the spec for backward compat. (as a wart) |
There was a problem hiding this comment.
Do we have any idea on how much usage of isFallbackAdapter exists?
It's technically a breaking change but I'm unaware of anyone using it. I read the spec text on isFallbackAdapter which makes it seem even less useful, rather the UA should implement the specification correctly or report WebGPU does not exist
|
WG meeting: approved. (Chromium will still do our homework) |
Spec PR: gpuweb/gpuweb#5099 Bug: 403172841 Change-Id: Icb3cfdeba682db01d5b8d434a686763743d40513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6347298 Commit-Queue: Fr <beaufort.francois@gmail.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/main@{#1434935}
Spec PR: gpuweb/gpuweb#5099 Bug: 403172841 Change-Id: Icda3d72cae665b0759ae7af674a22c383461c425 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/230674 Commit-Queue: Fr <beaufort.francois@gmail.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
It would only have performance caveats, but it's still required to be conformant. |
Following gpuweb/gpuweb#5099, this PR moves `isFallbackAdapter` into `GPUAdapterInfo`
GPU Web WG 2025-03-19 Atlantic-time
|
FIX #4971