Compat: remove adapter.featureLevel; add "core-features-and-limits" #5036

kainino0x · 2025-01-07T05:29:38Z

Stacked on #5056. You can ignore first commit for a cleaner diff.
The text here also assumes that no Compat features exist, which is not actually true until #5055 lands.

This PR applies the combination of choices the WG decided to move forward with on 2025-01-29, the main change being "webgpu-core" (which this PR was for originally, before updating it to account for the other stuff).

As discussed:

Removes adapter.featureLevel
Does not provide anything for Compat features (but includes notes on how they could be added later)
Adds "webgpu-core" feature (up for bikeshedding)

Original PR summary

This is a proposal.

This is separate from, but not in conflict with, adding features that lift each of the Compat restrictions (PR #5018). I think it is valuable either way. It provides several things:

Ability to check if an unnamed feature is available: adapter.features.has('specific-compat-feature') || adapter.features.has('webgpu-core'). This helps if we need to add a feature later and older browsers don't know that feature yet. Otherwise, the only way to deal with this is to call requestAdapter twice (first with core, then fallback to compat)[1].

With How to add features and limits for Compat after Core ships? #4987, adapter.hasCompatibilityFeature('specific-compat-feature') || adapter.features.has('webgpu-core')

Ability to check if a device was created with all core capabilities.

Along with this reduces the amount of API warts.

[1]: I think avoiding this is a design goal, but I'm not sure we ever decided that for sure. Would be good to resolve.

See #5037 for some extra discussion of removing adapter.featureLevel.

Issue: #4266, #4987
(Partially subsumes old PR #4898, subsumes #5037)

**DRAFT!!** Depends on gpuweb#5036 Issue: gpuweb#4266, gpuweb#4987 (With gpuweb#5036, subsumes old PR gpuweb#4898)

proposals/compatibility-mode.md

github-actions · 2025-01-10T02:09:17Z

Previews, as seen when this build job started (c543748):
WebGPU _{webgpu.idl | Explainer | Correspondence Reference}
WGSL _{grammar.js | wgsl.lalr.txt}

Kangz · 2025-01-27T16:01:09Z

GPU Web WG 2025-01-22 Atlantic-time

JB: How does this relate to How to add features and limits for Compat after Core ships? #4987? Do we still want this if we pick that?
KN: This lets you ask for a compat adapter, look at its feature, decide that if you’re missing something, to then ask for core.
- So this, if you ask for compat, can give you a core-compatible adapter back if you ask for this feature, but without this feature, it wouldn't be possible to lift all compat limitations.
BJ: What’s the benefit of this vs asking for core first, else asking for compat? It feels like thtt’s the same functionality, just asking in reverse?
KN: That would work, but:
- If it’s a feature that you want, you can check if the [compat] device if it has it.
- Avoids having to call requestAdapter twice, and the associated logic of picking features and limits etc.
KN: It’s not a huge advantage, but it does help a little.
BJ: So si this at device-creation?
KN: Yes
BJ: And that would remove the compat validation [on the resulting device?]?
KN: Right.
BJ: And if compat not implemented, if you just call requestAdapter with no args or with compat, you get the same thing?

greggman

lgtm

proposals/compatibility-mode.md

kainino0x · 2025-01-30T23:11:55Z

Oops, forgot to rebase over #5056 first. Done. PTAL! (also cc @mwyrzykowski since I can't re-request you)

greggman · 2025-02-05T23:12:50Z

@mwyrzykowski @jimblandy ok to merge?

jimblandy

This is approved, on the understanding that this PR is simply noting that we are still bikeshedding the name, and a later PR will actually record the result of that bikeshedding.

kainino0x · 2025-02-19T19:06:59Z

As agreed in the meeting, picked the name "core-features-and-limits". Applied that; landing the PR.

Reflecting gpuweb/gpuweb#5036 Bug: 395855517 Change-Id: I09ec62db124cb20496594b6b76ca4c931596256e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/226954 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Auto-Submit: Shrek Shao <shrekshao@google.com> Reviewed-by: Gregg Tavares <gman@google.com>

Kangz · 2025-03-05T16:38:50Z

GPU Web WG 2025-02-19 Atlantic-time

JB: want to make progress, doesn't commit us to anything. Mike and I both approved this PR at this point. Want to discuss the actual names.
KN: if people want to land this with the TODO we can do it. We want to start implementing it.
JB: Moz's first choice is "core-features-and-limits" - precise, but verbose.
KR: do you really want to write that in every WebGPU app?
JB: mostly for apps, not really demos.
KN: you really only write this if you care about supporting both Compat and Core.
CW: what's nice is it's forward-thinking - we will want to say "features and limits" in the future.
CW: OK, let's go with this.
KN: SGTM.

Reflecting gpuweb/gpuweb#5036 Bug: 395855517 Change-Id: I7d9164a6a0825c2636195dce32e41da61b839136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6307124 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/main@{#1430440}

kainino0x added the compat WebGPU Compatibility Mode label Jan 7, 2025

kainino0x added a commit to kainino0x/gpuweb that referenced this pull request Jan 7, 2025

Compat: remove GPUAdapter.featureLevel

665cbb8

**DRAFT!!** Depends on gpuweb#5036 Issue: gpuweb#4266, gpuweb#4987 (With gpuweb#5036, subsumes old PR gpuweb#4898)

This was referenced Jan 7, 2025

Compat: remove GPUAdapter.featureLevel #5037

Closed

Compat: describe as a featureLevel below core, upgradeable to core #4898

Closed

beaufortfrancois reviewed Jan 8, 2025

View reviewed changes

proposals/compatibility-mode.md Outdated Show resolved Hide resolved

greggman mentioned this pull request Jan 10, 2025

Compat: update new limits proposal #5034

Merged

kainino0x mentioned this pull request Jan 13, 2025

How to add features and limits for Compat after Core ships? #4987

Open

kainino0x added the proposal label Jan 13, 2025

kainino0x marked this pull request as ready for review January 14, 2025 00:11

mwyrzykowski self-requested a review January 21, 2025 22:56

kainino0x marked this pull request as draft January 29, 2025 22:18

kainino0x added this to the Milestone 1 milestone Jan 29, 2025

kainino0x force-pushed the compat-upgradeable-to-core branch 3 times, most recently from 5c05ede to d77d783 Compare January 30, 2025 03:05

kainino0x changed the title ~~Compat: add "webgpu-core" feature so Compat adapters can be Core-capable~~ Compat: remove adapter.featureLevel; add "webgpu-core" Jan 30, 2025

kainino0x force-pushed the compat-upgradeable-to-core branch from d77d783 to 239113a Compare January 30, 2025 23:02

kainino0x marked this pull request as ready for review January 30, 2025 23:03

kainino0x requested review from SenorBlanco, greggman and jimblandy January 30, 2025 23:03

greggman approved these changes Jan 30, 2025

View reviewed changes

proposals/compatibility-mode.md Outdated Show resolved Hide resolved

kainino0x force-pushed the compat-upgradeable-to-core branch from 239113a to b630b51 Compare January 30, 2025 23:11

no featureLevel, no compat features, yes "webgpu-core"

c543748

greggman force-pushed the compat-upgradeable-to-core branch from b630b51 to c543748 Compare February 5, 2025 22:50

mwyrzykowski approved these changes Feb 5, 2025

View reviewed changes

jimblandy approved these changes Feb 19, 2025

View reviewed changes

kainino0x self-assigned this Feb 19, 2025

Use the name "core-features-and-limits"

fdc5e94

kainino0x changed the title ~~Compat: remove adapter.featureLevel; add "webgpu-core"~~ Compat: remove adapter.featureLevel; add "core-features-and-limits" Feb 19, 2025

kainino0x merged commit 9ba16d7 into gpuweb:main Feb 19, 2025
4 checks passed

kainino0x deleted the compat-upgradeable-to-core branch February 19, 2025 19:08

shrekshao mentioned this pull request Feb 27, 2025

core-features-and-limits update gpuweb/cts#4228

Merged

shrekshao mentioned this pull request Mar 18, 2025

Manually add the core-features-and-limits feature name gpuweb/types#170

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Compat: remove adapter.featureLevel; add "core-features-and-limits" #5036

Compat: remove adapter.featureLevel; add "core-features-and-limits" #5036

Uh oh!

kainino0x commented Jan 7, 2025 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Jan 10, 2025 •

edited

Loading

Uh oh!

Kangz commented Jan 27, 2025

Uh oh!

greggman left a comment

Uh oh!

Uh oh!

kainino0x commented Jan 30, 2025

Uh oh!

greggman commented Feb 5, 2025

Uh oh!

jimblandy left a comment

Uh oh!

kainino0x commented Feb 19, 2025

Uh oh!

Uh oh!

Kangz commented Mar 5, 2025

Uh oh!

Uh oh!

Compat: remove adapter.featureLevel; add "core-features-and-limits" #5036

Compat: remove adapter.featureLevel; add "core-features-and-limits" #5036

Uh oh!

Conversation

kainino0x commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kangz commented Jan 27, 2025

Uh oh!

greggman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kainino0x commented Jan 30, 2025

Uh oh!

greggman commented Feb 5, 2025

Uh oh!

jimblandy left a comment

Choose a reason for hiding this comment

Uh oh!

kainino0x commented Feb 19, 2025

Uh oh!

Uh oh!

Kangz commented Mar 5, 2025

Uh oh!

Uh oh!

kainino0x commented Jan 7, 2025 •

edited

Loading

github-actions bot commented Jan 10, 2025 •

edited

Loading