这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@beaufortfrancois
Copy link
Contributor

FIX #2043

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2024

Previews, as seen when this build job started (b844f51):
WebGPU webgpu.idl | Explainer | Correspondence Reference
WGSL grammar.js | wgsl.lalr.txt

@kainino0x kainino0x added this to the Milestone 2 milestone Nov 1, 2024
@kainino0x kainino0x modified the milestones: Milestone 2, Milestone 1 Nov 1, 2024
@kainino0x
Copy link
Contributor

I created a milestone-0 branch which we'll use for the first CR snapshot. With that I think this can land in main.

@kainino0x kainino0x added api resolved Resolved - waiting for a change to the API specification api WebGPU API needs-cts-issue This change requires tests (or would need tests if accepted), but may not have a CTS issue filed yet labels Nov 1, 2024
@kainino0x kainino0x merged commit eea67b5 into main Nov 1, 2024
4 checks passed
@kainino0x kainino0x deleted the holes branch November 1, 2024 23:45
1. Let |limits| be |this|.{{GPUObjectBase/[[device]]}}.{{device/[[limits]]}}.
1. Let |bindGroupLayouts| be a copy of |descriptor|.{{GPUPipelineLayoutDescriptor/bindGroupLayouts}}
1. For each |i| in the [=list/get the indices|indices=] of |bindGroupLayouts|:
1. If |bindGroupLayouts|[|i|] is `undefined` or [=list/empty=], set |bindGroupLayouts|[|i|] to `null`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kainino0x I've just realized |bindGroupLayouts|[|i|] is [=list/empty=] is actually not defined in the spec as https://gpuweb.github.io/gpuweb/#gpubindgrouplayout is not a list per say. We obviously mean empty is a bind group layout with 0 entries but we may want to actually define this. WDYT?

Copy link
Contributor

@kainino0x kainino0x Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch, yes, we should say something like If |bindGroupLayouts|[|i|] is `undefined` or |bindGroupLayouts|[|i|].{{GPUBindGroupLayout/[[descriptor]]}}.{{GPUBindGroupLayoutDescriptor/entries}} is [=list/empty=]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's #4958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api resolved Resolved - waiting for a change to the API specification api WebGPU API needs-cts-issue This change requires tests (or would need tests if accepted), but may not have a CTS issue filed yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dealing with holes in the pipeline layout.

4 participants