-
Notifications
You must be signed in to change notification settings - Fork 345
Allow empty bindGroupLayouts in GPUPipelineLayoutDescriptor #4946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Previews, as seen when this build job started (b844f51): |
9d31e12 to
1caa775
Compare
|
I created a |
| 1. Let |limits| be |this|.{{GPUObjectBase/[[device]]}}.{{device/[[limits]]}}. | ||
| 1. Let |bindGroupLayouts| be a copy of |descriptor|.{{GPUPipelineLayoutDescriptor/bindGroupLayouts}} | ||
| 1. For each |i| in the [=list/get the indices|indices=] of |bindGroupLayouts|: | ||
| 1. If |bindGroupLayouts|[|i|] is `undefined` or [=list/empty=], set |bindGroupLayouts|[|i|] to `null`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kainino0x I've just realized |bindGroupLayouts|[|i|] is [=list/empty=] is actually not defined in the spec as https://gpuweb.github.io/gpuweb/#gpubindgrouplayout is not a list per say. We obviously mean empty is a bind group layout with 0 entries but we may want to actually define this. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good catch, yes, we should say something like If |bindGroupLayouts|[|i|] is `undefined` or |bindGroupLayouts|[|i|].{{GPUBindGroupLayout/[[descriptor]]}}.{{GPUBindGroupLayoutDescriptor/entries}} is [=list/empty=]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's #4958
FIX #2043