Add [SameObject] to several more attributes. #496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `[SameObject]` to the following attributes: - `GPUAdapter` `GPUDevice.adapter` - `Promise<GPUDeviceLostInfo>` `GPUDevice.lost` - `GPUError` `GPUUncapturedErrorEvent.error` In addition to these which already had it: - `GPUQueue` `GPUDevice.defaultQueue` - `GPU` `Navigator.gpu` - `GPU` `WorkerNavigator.gpu` Perhaps more important is which objects are *not* marked as `[SameObject]`: - `string` `GPUAdapter.name` - `string` `GPUDeviceLostInfo.message` - `string` `GPUValidationError.message` - `object` `GPUAdapter.extensions` - `object` `GPUAdapter.limits` (when it exists) - `object` `GPUDevice.extensions` - `object` `GPUDevice.limits` which means any additional properties added to these objects may not be preserved.
kvark
approved these changes
Nov 18, 2019
kdashg
approved these changes
Nov 25, 2019
Contributor
|
Discussed and approved in the 2019-11-25 meeting. |
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Nov 27, 2019
Spec change: gpuweb/gpuweb#496 Bug: 852089 Change-Id: I0b786ebaf3cb4084ecf755c9175c2fe51d9eca22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936693 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#719540}
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
For anything in `out/**/*` other than `out/**/*.js`, serve it statically from the `src/` directory. This makes reftests work by serving up their html but still relying on the automatic compilation of their typescript. Also adds 'start' script which makes `npm start` work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
[SameObject]to the following attributes:GPUAdapterGPUDevice.adapterPromise<GPUDeviceLostInfo>GPUDevice.lostGPUErrorGPUUncapturedErrorEvent.errorIn addition to these which already had it:
GPUQueueGPUDevice.defaultQueueGPUNavigator.gpuGPUWorkerNavigator.gpuPerhaps more important is which objects are not marked as
[SameObject]:stringGPUAdapter.namestringGPUDeviceLostInfo.messagestringGPUValidationError.messageobjectGPUAdapter.extensionsobjectGPUAdapter.limits(when it exists)objectGPUDevice.extensionsobjectGPUDevice.limitswhich means any additional properties added to these objects may not be
preserved.
Preview | Diff