Lower maxInterStageShaderVariables to 15 #4509
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value of `maxInterStageShaderVariables` should be 15 instead of 16 because in latest WebGPU SPEC any inter-stage shader variable will always consume 4 components, having 16 inter-stage shader variable will exceed the maximum value of `maxInterStageShaderComponents` (60).
Contributor
|
Previews, as seen when this build job started (be94f20): |
Contributor
|
From #1962 (comment) I believe that we don't need to reduce this limit, which makes the change much easier to do in the spec. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of
maxInterStageShaderVariablesshould be 15 instead of 16 because in latest WebGPU SPEC any user-definedinter-stage shader variable always consumes 4 components, then having 16 inter-stage shader variables will exceed the
maximum value of
maxInterStageShaderComponents(60).Bugs: #1962