Add "float32-blendable" feature #4896
Conversation
|
Previews, as seen when this build job started (eace419): |
|
Indeed the hardware supports rgba32float blending for all devices Metal is supported on. Additionally, there is no validation error either and tested locally this works. It is only the documentation which is out of date it seems. |
|
This addition might be simple enough that we can resolve it online rather than waiting for a WG meeting. Please review, and @mwyrzykowski @teoxoy let me know if you are providing "official" approval for the proposal to land! |
Yes, I support landing this into the specification |
This CL adds the float32-blendable feature which allows textures with formats "r32float", "rg32float", and "rgba32float" to be blendable. Spec PR: gpuweb/gpuweb#4896 Bug: 364987733 Change-Id: Iae3efd9d504c8c4800a8e622c1b82c4b3a25f755 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/210754 Commit-Queue: Fr <beaufort.francois@gmail.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
This CL exposes the float32-blendable feature behind the "Unsafe WebGPU support" flag so that we can start writing tests to the CTS. Note that it requires https://dawn-review.googlesource.com/c/dawn/+/210754. Spec PR: gpuweb/gpuweb#4896 Bug: 364987733, 369649348 Change-Id: Iae3efd9d504c8c4800a8e622c1b82c4b3a25f755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5929023 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/main@{#1369321}
Fixes #3556
Per #3556 (comment) we may not actually need to separate the features for r32float/rg32float blending and rgba32float blending. The only platform that could need that is Metal.
We need to confirm this is OK.Confirmed by Mike!Motivation: per #3556 (comment) this is a missing feature relative to WebGL (
EXT_float_blend), and other comments there indicate that people want to use this functionality.From Chrome's side, we'd like to add this feature because of a bug in Chrome that is currently allowing people to use float32 blending with just the
"float32-filterable"feature, and it would be nice if we provided this alternative before taking that away.