-
Notifications
You must be signed in to change notification settings - Fork 345
GPUDeviceLostReason "unknown" instead of undefined #3976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
CC @mwyrzykowski (also I invited you to the org so you can be added as a reviewer on PRs) |
mwyrzykowski
approved these changes
Mar 17, 2023
7 tasks
juj
added a commit
to juj/wasm_webgpu
that referenced
this pull request
Aug 4, 2023
copybara-service bot
pushed a commit
to google/dawn
that referenced
this pull request
May 3, 2024
Spec change was: gpuweb/gpuweb#3976 Stage 1: `Undefined` and `Unknown` coexist. Bug: chromium:42241081 Change-Id: Ic530d216e6935aa8c09cf5a056b74bb797445d7a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/186585 Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Ho Cheung <hocheung@chromium.org>
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
May 4, 2024
Spec change was: gpuweb/gpuweb#3976 Stage 2: Replace `Undefined` in Blink. Bug: 42241081 Change-Id: I607f29194bb699da12bf2a5f7ea88bae2fc2fea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5515677 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Ho Cheung <hocheung@chromium.org> Cr-Commit-Position: refs/heads/main@{#1296500}
copybara-service bot
pushed a commit
to google/dawn
that referenced
this pull request
May 7, 2024
Spec change was: gpuweb/gpuweb#3976 Stage 3: Remove `WGPUDeviceLostReason_Undefined` from Dawn. Bug: chromium:42241081 Change-Id: I6865a9cff2494adadab4dbae898ab010401afb94 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/187280 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
copybara-service bot
pushed a commit
to google/dawn
that referenced
this pull request
May 8, 2024
This reverts commit 98012bf. Reason for revert: This breaks the Dawn->Chromium roll because not all usages have been updated yet. We need Emscripten to be updated with this change before we can update the remaining usages. Original change's description: > (3/N) Rename WGPUDeviceLostReason_Undefined to Unknown > > Spec change was: > gpuweb/gpuweb#3976 > > Stage 3: Remove `WGPUDeviceLostReason_Undefined` > from Dawn. > > Bug: chromium:42241081 > Change-Id: I6865a9cff2494adadab4dbae898ab010401afb94 > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/187280 > Commit-Queue: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Austin Eng <enga@chromium.org> > Reviewed-by: Kai Ninomiya <kainino@chromium.org> TBR=kainino@chromium.org,enga@chromium.org,dawn-scoped@luci-project-accounts.iam.gserviceaccount.com,hocheung@chromium.org Change-Id: Iaddff04864e965a7d473a737721d52e40be72b06 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:42241081 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/187480 Reviewed-by: James Price <jrprice@google.com> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: James Price <jrprice@google.com>
copybara-service bot
pushed a commit
to google/dawn
that referenced
this pull request
May 13, 2024
This reverts commit a105651. Reason for revert: All affected code has been modified, and we are now attempting to reland the patch. Original change's description: > Revert "(3/N) Rename WGPUDeviceLostReason_Undefined to Unknown" > > This reverts commit 98012bf. > > Reason for revert: This breaks the Dawn->Chromium roll because not all usages have been updated yet. We need Emscripten to be updated with this change before we can update the remaining usages. > > Original change's description: > > (3/N) Rename WGPUDeviceLostReason_Undefined to Unknown > > > > Spec change was: > > gpuweb/gpuweb#3976 > > > > Stage 3: Remove `WGPUDeviceLostReason_Undefined` > > from Dawn. > > > > Bug: chromium:42241081 > > Change-Id: I6865a9cff2494adadab4dbae898ab010401afb94 > > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/187280 > > Commit-Queue: Kai Ninomiya <kainino@chromium.org> > > Reviewed-by: Austin Eng <enga@chromium.org> > > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > > TBR=kainino@chromium.org,enga@chromium.org,dawn-scoped@luci-project-accounts.iam.gserviceaccount.com,hocheung@chromium.org > > Change-Id: Iaddff04864e965a7d473a737721d52e40be72b06 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:42241081 > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/187480 > Reviewed-by: James Price <jrprice@google.com> > Reviewed-by: Austin Eng <enga@chromium.org> > Commit-Queue: James Price <jrprice@google.com> # Not skipping CQ checks because this is a reland. Bug: chromium:42241081 Change-Id: I878465702fc70266875001e947c973555bd0f839 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/187560 Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
May 15, 2024
Spec change was: gpuweb/gpuweb#3976 Stage 4: Delete the code related to `WGPUDeviceLostReason_Undefined` in blink. Bug: 42241081 Change-Id: Ic0acf7ef49191ea68959fcb5090a31566b303750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5541054 Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Ho Cheung <hocheung@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/main@{#1301298}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3894