Add defaults to GPUTextureViewDescriptor, remove createDefaultView #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdashg
approved these changes
Aug 6, 2019
Jiawei-Shao
reviewed
Aug 12, 2019
| GPUTextureViewDimension dimension; | ||
| GPUTextureAspect aspect = "all"; | ||
| u32 baseMipLevel = 0; | ||
| u32 mipLevelCount = 1; |
Contributor
There was a problem hiding this comment.
Should "default texture view" cover all the mipmap levels and the array layers instead of the first ones?
Contributor
There was a problem hiding this comment.
it absolutely should (great point!), if we are going this way
we could make the mipLevelCount=0 to have this special semantics here
Contributor
Author
There was a problem hiding this comment.
I agree. Would you open another PR for this?
Contributor
Author
|
This has been open a while and I'm pretty confident that it's uncontroversial. Rerunning travis and merging. |
Contributor
Author
|
(with #407, which I'm merging too) |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 23, 2019
gpuweb/gpuweb#389 Bug: dawn:214 Change-Id: I4450e9abcc1f202b3107b2ed42f54626f896f874
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 23, 2019
gpuweb/gpuweb#389 Bug: dawn:214 Change-Id: I4450e9abcc1f202b3107b2ed42f54626f896f874
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 23, 2019
gpuweb/gpuweb#389 Bug: dawn:214 Change-Id: I4450e9abcc1f202b3107b2ed42f54626f896f874
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Aug 27, 2019
gpuweb/gpuweb#389 Bug: dawn:214 Change-Id: I4450e9abcc1f202b3107b2ed42f54626f896f874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766765 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#690746}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 27, 2019
gpuweb/gpuweb#389 Bug: dawn:214 Change-Id: I4450e9abcc1f202b3107b2ed42f54626f896f874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766765 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#690746}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 27, 2019
gpuweb/gpuweb#389 Bug: dawn:214 Change-Id: I4450e9abcc1f202b3107b2ed42f54626f896f874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766765 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#690746}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Aug 29, 2019
…estonly Automatic update from web-platform-tests Remove GPUTexture.createDefaultView gpuweb/gpuweb#389 Bug: dawn:214 Change-Id: I4450e9abcc1f202b3107b2ed42f54626f896f874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766765 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#690746} -- wpt-commits: dc25cd389029b34cd368f326e59ac1810498524e wpt-pr: 18624
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Aug 30, 2019
…estonly Automatic update from web-platform-tests Remove GPUTexture.createDefaultView gpuweb/gpuweb#389 Bug: dawn:214 Change-Id: I4450e9abcc1f202b3107b2ed42f54626f896f874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766765 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#690746} -- wpt-commits: dc25cd389029b34cd368f326e59ac1810498524e wpt-pr: 18624
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…estonly Automatic update from web-platform-tests Remove GPUTexture.createDefaultView gpuweb/gpuweb#389 Bug: dawn:214 Change-Id: I4450e9abcc1f202b3107b2ed42f54626f896f874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766765 Reviewed-by: Corentin Wallez <cwallezchromium.org> Reviewed-by: Austin Eng <engachromium.org> Commit-Queue: Kai Ninomiya <kaininochromium.org> Cr-Commit-Position: refs/heads/master{#690746} -- wpt-commits: dc25cd389029b34cd368f326e59ac1810498524e wpt-pr: 18624 UltraBlame original commit: 46ce1c209c17ce99f3090d6dbe179e018424fea7
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
…estonly Automatic update from web-platform-tests Remove GPUTexture.createDefaultView gpuweb/gpuweb#389 Bug: dawn:214 Change-Id: I4450e9abcc1f202b3107b2ed42f54626f896f874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766765 Reviewed-by: Corentin Wallez <cwallezchromium.org> Reviewed-by: Austin Eng <engachromium.org> Commit-Queue: Kai Ninomiya <kaininochromium.org> Cr-Commit-Position: refs/heads/master{#690746} -- wpt-commits: dc25cd389029b34cd368f326e59ac1810498524e wpt-pr: 18624 UltraBlame original commit: 46ce1c209c17ce99f3090d6dbe179e018424fea7
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…estonly Automatic update from web-platform-tests Remove GPUTexture.createDefaultView gpuweb/gpuweb#389 Bug: dawn:214 Change-Id: I4450e9abcc1f202b3107b2ed42f54626f896f874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766765 Reviewed-by: Corentin Wallez <cwallezchromium.org> Reviewed-by: Austin Eng <engachromium.org> Commit-Queue: Kai Ninomiya <kaininochromium.org> Cr-Commit-Position: refs/heads/master{#690746} -- wpt-commits: dc25cd389029b34cd368f326e59ac1810498524e wpt-pr: 18624 UltraBlame original commit: 46ce1c209c17ce99f3090d6dbe179e018424fea7
bhearsum
pushed a commit
to mozilla-releng/staging-firefox
that referenced
this pull request
May 1, 2025
…estonly Automatic update from web-platform-tests Remove GPUTexture.createDefaultView gpuweb/gpuweb#389 Bug: dawn:214 Change-Id: I4450e9abcc1f202b3107b2ed42f54626f896f874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766765 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#690746} -- wpt-commits: dc25cd389029b34cd368f326e59ac1810498524e wpt-pr: 18624
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These defaults seem reasonable and unsurprising to me.
I feel like we must have discussed these already before, but it's really hard to find anything about it in our GitHub issues.
Preview | Diff