这是indexloc提供的服务，不要输入任何密码
Skip to content

Remove Bit/Bits from bitmasks #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2019
Merged

Remove Bit/Bits from bitmasks #292

merged 1 commit into from
Jul 9, 2019

Conversation

@Kangz
Copy link
Contributor

@Kangz Kangz commented May 11, 2019 •
edited by pr-preview bot
Loading

@Kangz
Copy link
Contributor Author

Kangz commented May 22, 2019

@RafaelCintron @litherum @JusSn can I get an extra review?

@kdashg
Copy link
Contributor

kdashg commented Jun 3, 2019

What's the reasoning here?

@kdashg
Copy link
Contributor

kdashg commented Jun 3, 2019

I'll make a PR to instead consistently use FooBit[s]/FooFlag[s].

@kdashg kdashg mentioned this pull request Jun 6, 2019
Closed
kdashg
kdashg requested changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@kdashg kdashg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking symmetrically until we figure out which approach we want.

@kdashg
Copy link
Contributor

kdashg commented Jul 8, 2019

Please rebase!

@Kangz
Copy link
Contributor Author

Kangz commented Jul 9, 2019

Merging this as was discussed in yesterday's call.

@Kangz Kangz merged commit fdea6bf into gpuweb:master Jul 9, 2019
@Kangz Kangz deleted the bits branch July 9, 2019 08:21
aarongable pushed a commit to chromium/chromium that referenced this pull request Jul 15, 2019
@beaufortfrancois
[WebGPU] Remove Bit/Bits from bitmasks
e2cd139 
Following WebGPU spec change at gpuweb/gpuweb#292,
bit and bits should be removed from GPUShaderStageBit and GPUColorWriteBits.

Bug: 877147
Change-Id: Ic4304d4027735d0990b7435cf4e2a732fd9fd3e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702001
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#677313}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kvark kvark kvark approved these changes

@kainino0x kainino0x kainino0x approved these changes

@kdashg kdashg kdashg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kangz @kdashg @kvark @kainino0x