-
Notifications
You must be signed in to change notification settings - Fork 329
Replace "sampled-texture" with "ro-texture" #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
And add a TODO for "rw-texture". Supersedes gpuweb#190.
Uploading this for discussion to replace #190. Myles's usage table:
|
Same comment as in the other PR: I don't think we should do this for two reasons:
So like for buffers I'd suggest we keep the current names for textures, and plan to add a |
@Kangz |
The other motivation is consistency with buffer. No I don't have references at this point. |
Discussed at the 1 April Teleconference |
Consensus: Prefer sampled-texture name. |
Oh, I didn't realize that's what the group preferred. What about the fact that some users may use this kind of texture without ever sampling from it (only loading instead)? To clarify my position: I think it should be just "texture", given that 95% of use cases (roughly!) are just that, and it's easily recognizable and matching HLSL. I don't quite see how the argument about barriers apply here: we aren't inventing new concepts, the difference between regular textures and storage/rw ones is well known, and we don't anticipate any new kinds there. |
* Add validation tests for CopyBufferToBuffer This patch adds all the validation tests about CopyBufferToBuffer(). 1. Both the source and destination buffer must be valid. 2. The source buffer must have COPY_SRC usage and the destination buffer must have COPY_DST usage. 3. The copySize must be a multiple of 4. 4. Both the source and destiantion offset are multiple of 4. 5. Both (srcOffset + copySize) and (dstOffset + copySize) must not overflow a buffer. 6. The source buffer and destination buffer cannot be the same one. * Address reviewer's comments * dos2unix * Fix coding style * More coding style fix * More fix * Address reviewer's comments * Fix coding style * Small fix
And add a TODO for "rw-texture".
Supersedes #190.