Consolidate *loadOp and clear* into a unioned field #283
Conversation
spec/index.bs
Outdated
| "load" | ||
| "load", | ||
| "opaqueBlack", | ||
| "zero" |
There was a problem hiding this comment.
opaqueBlack and zero are up for discussion.
There was a problem hiding this comment.
Prefer not to duplicate functionality of GPUColor.
spec/index.bs
Outdated
| "load" | ||
| "load", | ||
| "opaqueBlack", | ||
| "zero" |
There was a problem hiding this comment.
Prefer not to duplicate functionality of GPUColor.
That's exactly what #276 did, and your feedback was that it was "gross". TL;DR: defaulting to non-clear is bad for performance |
|
My opinions are mutable, and my comment was made for my /Approval/ of that PR! My preferences:
|
|
Merging with verbal approval in the meeting from Myles, Rafael, and others. |
Following WebGPU spec change at gpuweb/gpuweb#283, this CL makes sure *loadOp and clear* are consolidated into an unioned field in GPURenderPassColorAttachmentDescriptor and GPURenderPassDepthStencilAttachmentDescriptor. Bug: 877147 Change-Id: I4a676e8cfa52844f2df54b6201e6db453c1d9e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715267 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#680373}
* Add texture usage validation scope test Resource usages validation should be done per each render pass. Inside a pass, resource usage conflict should always validated. But resource usage conflict between passes is not a problem. * Address Kai's feedback: put createNoOpRenderPipeline to a function in ValidationTest * code rebase * Address Kai's feedback: separate into a few tests
Followup to #276.
Preview | Diff