-
Notifications
You must be signed in to change notification settings - Fork 345
Add indirect-first-instance feature. #2022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add indirect-first-instance feature. #2022
Conversation
|
@tidoust ipr is blocking this change - does @mrshannon really need to be in the working group to land this change? I thought our model was to do IP rubber-stamping in bulk when the spec is imported from the community group to the working group. |
|
For the record: in the meeting we resolved to accept this change. |
The notion of "rubber-stamping" tends to irk legal departments... The goal of the IPR bot is to alert the Working Group about situations where it is effectively going to incorporate a substantive contribution from a participant who did not make the exact same IPR commitments as WG participants. CG participants contributions are covered by the CLA. WG participants contributions are covered by the W3C Patent Policy. The CLA does provide some level of RF guarantees. The W3C Patent Policy is a bit stronger than the CLA. The goal is to secure as many RF guarantees as we can for the final W3C Recommendation. To solve this:
|
The only option that page currently lists is to join the GPU for the Web Working Group. It is very likely I can sign the FSA, but there is currently no means to continue along that route. I have already signed the CLA, when I joined the CG last year. |
|
I have permission to sign the FSA, but no way to sign it as the IPR is still blocked on WG only. |
|
@tidoust can you confirm if there should be a way to sign the FSA without joining the working group? Otherwise we can probably figure out how to get him into the WG as an invited expert? Or we can override the change but we'd want to get WG approval which we don't have a process for. |
|
@tidoust how does one override the IPR bot? I see @Ash-Nazg mentioned often but I don't know who owns that github account. @mrshannon has been blocked on this process for a fairly trivial contribution (adding an optional feature that lifts a restriction in the spec). How can he sign the FSA without joining the WG itself? It seems all that matters is the FSA. |
|
FWIW we can always admin-override to merge it, once we know the FSA is signed. |
|
Someone not from WG signed FSA? If yes, how they do that? |
|
I hate to bump this again, but is there any update on being able to sign the FSA as a CG member? |
|
@tidoust this PR has been blocked for months on CG members not being able to sign the FSA. Any way we can escalate? |
|
Oh no! Sorry this has languished for months, mentions of my name did not trigger the notifications I was expecting so I simply hadn't seen this. There is a way to ask for non-member commitments through the IPR bot with two caveats:
I just did that for this PR. @mrshannon, please check your email inbox for a link to the relevant online form. |
|
Agreement completed. Once this PR is merged I will rebase #1949 on this and ping that one as well. Thanks. |
|
And IPR bot turned green as a result, so all good! |
b72313a to
6fb73a5
Compare
Combining indirect drawing with render bundles is a powerful way to shift work to the GPU. However, with
firstInstancelocked to 0 the bundle must use dynamic uniform/storage buffer offsets which cannot be changed once the bundle is encoded. With non-zero values offirstInstancetheinstance_indexcan be used to index into uniform/storage arrays inside the shader, allowing the GPU to change what is rendered each frame, greatly adding to the flexibility of render bundles.This PR addresses adding an
indirect-first-instancefeature which aims to relax the requirement onfirstInstance = 0fordrawIndirectanddrawIndexedIndirecton hardware which supportsfirstInstance > 0.NOTE: The decision to split this feature off from #1949 was made during the meeting on 2021-08-02
NOTE: This was removed from core (#1878) due to the 36% of Android devices which do not support
firstInstance > 0.The required backend capabilities to implement
indirect-first-instanceare available on:In particular, the required capabilities are core to DX12 and Metal, but requires the
drawIndirectFirstInstancefeature on Vulkan. The corresponding parameter for each backend API are given in the table below:firstInstanceStartInstanceLocationbaseInstancePreview | Diff