-
Notifications
You must be signed in to change notification settings - Fork 346
[wgsl] Add access qualifier to buffer types #1183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note this uses a slightly different |
dneto0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Discussed at 2020-11-03 meeting. |
|
I'll take one more crack at this. It goes back to the distinction between values (which are mathematical things) and variables (which are storage constructs in a computer). From the spec, section Variable and const:
The store type is the thing we write after the colon. So in What we have is that For a buffer variable, the store type describes the contents of the storage. We describe it with a struct with members (including layout. #1215). Contrast that with textures and samplers, which are opaque: they have no internal structure that we can poke at with WGSL expressions. There is no internal structure to the "store type". So in sum:
|
dneto0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad we can make forward progress.
|
Discussed at 2020-11-17 meeting. |
This CL adds the ability to provide an `access(read|read_write)` to a buffer type. This is only available for storage variables. Issue #1159
|
Updated to remove the access, read and read_write token. Uses the variable_declaration_list instead. |
This PR creates a shader/validation/parse folder and moves the WGSL parsing tests into the folder. The tests are split out by type to make the test files more targeted. For the var/let cases half of them are in the shader_io folder where they relate to IO sharable types.
This CL adds the ability to provide an
access(read|read_write)to abuffer type. This is only available for storage variables.
Issue #1159