Add multisampled texture type #1029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dj2
approved these changes
Aug 25, 2020
kdashg
approved these changes
Aug 25, 2020
|
Approved to land after rebase. |
|
Rebased now |
ponitka
reviewed
Aug 26, 2020
| @@ -2977,11 +2990,15 @@ TODO: deduplicate these tables | |||
| `vec4<type> textureLoad(texture_ro, i32 coords, i32 level_of_detail)` | |||
| `vec4<type> textureLoad(texture_ro, vec2<i32> coords, i32 level_of_detail)` | |||
| `vec4<type> textureLoad(texture_ro, vec3<i32> coords, i32 level_of_detail)` | |||
| %32 = OpImageFetch %v4float %texture_ro %coords Lod %level_of_detail | |||
| %32 = OpImageLoad %v4float %texture_ro %coords Lod %level_of_detail | |||
There was a problem hiding this comment.
Shouldn't this be OpImageRead?
There was a problem hiding this comment.
Oh yes, that's a mistake. Would you want to make a PR fixing this?
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
…puweb#1029) copyImageBitmapToTexture is deprecated API and it has been removed from cts tests. But the word copyImageBitmapToTexture remains in comments and readme. This commit replaces it with copyExternalImageToTexture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #990