Updated validation rules for pipeline index formats #1022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
approved these changes
Aug 24, 2020
Kangz
approved these changes
Aug 24, 2020
Contributor
|
Note the IPR "red flag" can be ignored and the pull request merged without problem. The IPR bot complains about the pull request because:
The IPR bot would not have complained in WG mode since Google already joined the WG, and since the W3C Patent Policy applies at the organizational level. In short, the pull request is covered by the W3C Patent Policy. |
Member
Author
|
For what it's worth, I've sent off the request to join the CG to avoid this in the future. Thanks! |
bb4b73f to
215d567
Compare
Member
Author
|
Rebased and the travis issue went away, plus the IPR check is passing too now! |
kainino0x
approved these changes
Aug 26, 2020
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
* Update some setup code with the addition of new message-passing test * Factor out more common code * Refactor result shader generation * Parameterize all tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #767, I believe.
Fixes one minor
null/undefinedmismatch, allows the pipelineindexFormatto beundefined, and specifies that strip topologies must have a defined index format while non-strip topologies must have anundefinedindex format.BTW: Giving the "switch" statement in bikeshed a try here, let me know what you think of the formatting! I feel like it helps readability in this case.
Preview | Diff