New binding type for multisampled textures #1005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kainino0x
approved these changes
Aug 17, 2020
Contributor
kainino0x
left a comment
There was a problem hiding this comment.
LGTM, looks like a straightforward clarifying refactor of the same information.
Kangz
approved these changes
Aug 18, 2020
Contributor
Kangz
left a comment
There was a problem hiding this comment.
Nice, that makes things much simpler indeed.
Contributor
Author
|
Thanks for the reviews! I rebased this now. Would be great to not wait another 2 weeks for this to be discussed. |
kainino0x
approved these changes
Aug 19, 2020
Contributor
It will be on the agenda for next week. |
Contributor
|
Discussed at the 2020-08-24 meeting. |
kdashg
approved these changes
Aug 24, 2020
Contributor
|
Resolution: rebase and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #990
Problem: on the shader side, MSAA-enabled textures are not sampled. We have the
texture_loadinstruction to access them, andtexture_sampleis forbidden (in WGSL). Therefore, it's confusing to bind them as "sampled-texture" types. This PR adds a new binding type specifically for MSAA textures, and it removes the old booleanmultisampledfrom BGL entry.Preview | Diff