[wgsl] Update Goals section of spec #588
Conversation
|
Did anyone else have feedback on this change? |
|
(oops, apologies, I confused this with a different pr!)
Get Outlook for Android<https://aka.ms/ghei36>
…________________________________
From: Damyan Pepper <damyanp@microsoft.com>
Sent: Tuesday, March 10, 2020 9:07:26 AM
To: gpuweb/gpuweb <gpuweb@noreply.github.com>; gpuweb/gpuweb <reply@reply.github.com>
Cc: Comment <comment@noreply.github.com>
Subject: Re: [gpuweb/gpuweb] [wgsl] Update Goals section of spec (#588)
I haven't had a chance to review it, but would like to in the next hour or two.
Get Outlook for Android<https://aka.ms/ghei36>
________________________________
From: dan sinclair <notifications@github.com>
Sent: Tuesday, March 10, 2020 8:46:42 AM
To: gpuweb/gpuweb <gpuweb@noreply.github.com>
Cc: Damyan Pepper <damyanp@microsoft.com>; Comment <comment@noreply.github.com>
Subject: Re: [gpuweb/gpuweb] [wgsl] Update Goals section of spec (#588)
Did anyone else have feedback on this change?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgpuweb%2Fgpuweb%2Fpull%2F588%3Femail_source%3Dnotifications%26email_token%3DAB56BAX5YOJY67TG4APFRLDRGZOGFA5CNFSM4LAS5XC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOL63BI%23issuecomment-597159301&data=02%7C01%7Cdamyanp%40microsoft.com%7C3a01445a567c4cd563e108d7c50a3af1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637194520030950458&sdata=z4%2B%2BGTUANQ9PEAgQCM5PRGkjyPK5OvqP1tzZFQSHvi4%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAB56BATRRMYJN43IP7C5DYLRGZOGFANCNFSM4LAS5XCQ&data=02%7C01%7Cdamyanp%40microsoft.com%7C3a01445a567c4cd563e108d7c50a3af1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637194520030960414&sdata=jUk7GqUygqi2k7sQb5xglgo%2FQ9JN5H%2FRVuHBbxLZIww%3D&reserved=0>.
|
|
#599 includes the result of our telecon last week. |
The minutes from last week https://docs.google.com/document/d/15Pi1fYzr5F-aP92mosOLtRL4qLczmVRWQaomfQmGNzo/edit?ts=5e5d1f8e#bookmark=id.f4tachha289j say:
Dan posted this PR on the same day. So #599, which was posted 15hrs ago, should not have tried to address the parts addressed in this PR. |
Ah, I must have mis-remembered my action item. I'll rebase mine on top of this one. |
| * Constructs are defined as normative references to their SPIR-V counterparts | ||
| * All features in [SHORTNAME] are directly translatable to SPIR-V. (No polymorphism, no general pointers, no overloads, etc) | ||
| * Features and semantics are exactly the ones of SPIR-V | ||
| * Each item in this spec *must* provide the mapping to SPIR-V for the construct |
There was a problem hiding this comment.
We should probably join these two together into a single item. What's the difference between "constructs" and "items?"
It also seems that they aren't really goals, but instead are a means to achieving the "simple and efficient conversion from SPIR-V." These two probably belong in the README instead.
There was a problem hiding this comment.
In my mind these two are different to the simple and efficient conversion goal. The key part here is that the semantics of WGSL are inherited from SPIR-V. This is why we can have confidence that WGSL works as a shader language and doesn't specify things that are inherently hard or ambiguous across multiple GPU architectures. This is how WGSL leverages all the work that has been done to ensure this in SPIR-V.
There was a problem hiding this comment.
I'm in agreement with @damyanp here. The semantics of SPIR-V are an important goal for WGSL.
|
ping |
|
Closing for now, we can revisit after the FAQ work is done. |
This CL updates the goals section with the original language combined
with the discussion from #586 and the weekly meeting.
Issue #586