Make time elapsed work when using Set() #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dot-deamon
added a commit
to dot-deamon/uiprogress
that referenced
this pull request
Nov 29, 2019
dot-deamon
added a commit
to dot-deamon/uiprogress
that referenced
this pull request
Nov 29, 2019
dot-deamon
added a commit
to dot-deamon/uiprogress
that referenced
this pull request
Nov 29, 2019
vcschapp
suggested changes
Sep 28, 2021
Comment on lines
+98
to
+100
| if b.TimeStarted.IsZero() { | ||
| b.TimeStarted = time.Now() | ||
| } |
There was a problem hiding this comment.
Would you consider the alternative of using implementing Incr() by reusing Set()? This would result in more reused code and less code overall, less opportunity for error.
Ideally there would be a test as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the variables needed to show time elapsed are only set when using
Incr(). This PR makes it also work when usingSet().