@henvic works for me from the functional point of view.

@mgurov, what about now? I have done the same changes on uilive as well.

@henvic LGTM now. My comments are addressed. Thank you!

Hey @mgurov,

If you run the tests repeatedly (just do while true; do go test; done) you will see they fail from time to time (even though my examples are running flawlessly).

I have tried adding even a time.Sleep(2 * p.RefreshInterval) on the Stop() of uiprogress and uilive just after close(), but it doesn't do any difference. Any ideas of what may be going on? Thanks.

@henvic two things.

First, if you run make test repeatedly you'll soon hit race conditions because the newly added test uses unsynchronized bytes.Buffer for progress and for fmt.Fprintf(buffer, "foo"). Adding some form of synchronization would help.

Second, as far as I can see there is no strict guarantee that your fmt.Fprintf(buffer, "foo") will happen after the last flush at the case <-p.ticker.C of the Listener(). Say the signal from the ticker arrived at the same moment Stop() has just acquired the write lock. Ticker handling will proceed after the Stop() is done, on a collision course with the fmt.Fprintf, occasionally leading to a suffix different than you expect in the test.

@mgurov,
why would you hit race conditions given that while true; do go test; done runs several, independent processes, and in series (as in, each one after the previous exited)? It doesn't make sense for me.

Actually note that this might happen even for just one test. I said to run it repeatedly because it'd be easier for the issue to be replicated.

I think with these last changes the synchronization issue is gone.

👍 for merge

@xorpaul, if you are blocked while these fixes doesn't make mainstream you can temporarily use my fork (or better, do a fork of this repo yourself and do what I did in order for you to keep track you're not using the official version). It is set with the fix-race-condition-on-stop-henvic branch as the default one and the uilive dependency there is pointing to a uilive with these fixes as well, so you can just 'go get' and use it (or do the same for uilive). Just need to replace gosuri with henvic on your code.

@henvic Yeah, thanks for the suggestion, but I am already using your fork 😄

great! thanks so much