Added bypass writer which allows data to be written to the underlying output #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… output. By clearing the uilive.Writer lines and resetting the line count, log output (for example) can be written to the underlying output without being overwritten by the next update from the buffer.
Owner
|
LGTM! Reviewing the other PR. Thank you. |
gosuri
pushed a commit
that referenced
this pull request
Feb 2, 2016
Added bypass writer which allows data to be written to the underlying output
Contributor
Author
|
Great - thanks for the excellent progress indicator! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is something you actually want, but I've found it convenient to still be able to output log messages while the uiprogress output is running. At the moment, any 'normal' output gets overwritten by the next refresh of the uilive buffer, and you end up with lots of progress bars left behind due to the output getting out of sync.
By clearing the uilive.Writer lines and resetting the line count, log output (for example) can
be written to the underlying output without being overwritten by the next update from the
buffer.
I've also exposed a similar method on the uiprogress.Progress object, which I will create a PR for.