Support for intermediate writers. #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Cool. Thank you. |
gosuri
pushed a commit
that referenced
this pull request
Dec 23, 2015
Support for intermediate writers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows it's impossible right now to output to colorized writers, such as mattn/go-colorable, since they need to wrap the
*os.Filein their own implementation ofio.Writer, thus losing access to the terminal's file descriptor.The code now checks for
FdWriter, an interface type that*os.Fileimplements out of the box. This way one can forward the terminal's file descriptor to uilive while using an intermediate writer.FdWriterdidn't really need to be exported but I don't like the idea of some types having different behaviour based on an undocumented API.