Fix wrong screen drawing by not counting ASCII color codes #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code assumed that it could count every byte in the current line towards the length of the visible line. With invisible characters, though, such as ASCII color codes, the count was wrong and lead to the output to "climb up the screen" because the overflow handling broke and too many newlines were emitted. The fix here introduces a little "state switch" that flips on when we come across an ESC character and turns to off when we come across 'm', the character that terminates an ASCII color code.
mrnugget
added a commit
to sourcegraph/src-cli
that referenced
this pull request
Jan 28, 2020
mrnugget
added a commit
to sourcegraph/src-cli
that referenced
this pull request
Jan 28, 2020
* Update all dependencies * Use forked version of uilive that includes fix for "climbing" screen See gosuri/uilive#30 for context
scjohns
pushed a commit
to sourcegraph/src-cli
that referenced
this pull request
Apr 24, 2023
* Update all dependencies * Use forked version of uilive that includes fix for "climbing" screen See gosuri/uilive#30 for context
|
why not accept this PR |
Adaendra
added a commit
to Adaendra/uilive
that referenced
this pull request
Jul 22, 2023
|
Hi @mrnugget |
Author
|
Thanks @Adaendra for letting me know! We've moved on to a different library in the past 2 years, so this is not needed, but appreciate it. (We're now using this I'm going to close the PR then. |
DevStar411112
added a commit
to DevStar411112/src-cli
that referenced
this pull request
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code assumed that it could count every byte in the current
line towards the length of the visible line.
With invisible characters, though, such as ASCII color codes, the count
was wrong and lead to the output to "climb up the screen" because the
overflow handling broke and too many newlines were emitted.
The fix here introduces a little "state switch" that flips on when we
come across an ESC character and turns to off when we come across 'm',
the character that terminates an ASCII color code.
Here is code to reproduce the issue: https://gist.github.com/mrnugget/f46caf71b214ae6b6ffa9880a0036003
Notably missing: not all characters that end an escape sequence are supported.
Before
After