这是indexloc提供的服务,不要输入任何密码
Skip to content

chore!: migrate to Node 18 #2271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 50 commits into from
Apr 23, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
418e47d
feat: add a last field in the PartialResultSet
gcf-owl-bot[bot] Feb 25, 2025
93f57f2
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 25, 2025
40a64c9
chore: update copyright year for auto-generated protos
gcf-owl-bot[bot] Feb 27, 2025
97e9017
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 27, 2025
d35de6e
chore: update copyright year for auto-generated protos
gcf-owl-bot[bot] Feb 28, 2025
042b4f7
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 28, 2025
1eec8f7
chore: update typescript gapic generator to 4.8.1
gcf-owl-bot[bot] Mar 12, 2025
1c45031
feat: await/catch promises, and update listOperationsAsync return type
gcf-owl-bot[bot] Mar 19, 2025
198a5b4
chore: run post-processor locally
sofisl Apr 3, 2025
2bd3257
chore: migrate to node 18
alkatrivedi Apr 1, 2025
4d27fcc
fix: imports
alkatrivedi Apr 1, 2025
d7017b8
changes in tsconfig
alkatrivedi Apr 1, 2025
563e907
fix: import errors
alkatrivedi Apr 1, 2025
bc1540a
remove script
alkatrivedi Apr 1, 2025
9e21e42
update tsconfig
alkatrivedi Apr 2, 2025
0aa8a32
fix: eslint errors
alkatrivedi Apr 7, 2025
e93c5c2
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Apr 7, 2025
1f8b805
downgrade dependencies arrify, pqueue, time-span, stack-trace
alkatrivedi Apr 8, 2025
a017729
add spanProcessors property and remove addSpanProcessor
alkatrivedi Apr 8, 2025
1910d92
fix: eslint issues and unit tests
alkatrivedi Apr 11, 2025
b1d7cbf
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Apr 11, 2025
66e3922
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Apr 11, 2025
ebf9e3a
fix: unit test
alkatrivedi Apr 11, 2025
fb6b247
fix: presubmit errors
alkatrivedi Apr 11, 2025
fbb9dc6
add node-18 directory
alkatrivedi Apr 11, 2025
e879ce9
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Apr 11, 2025
5ecfa2c
rename node-18 directory
alkatrivedi Apr 11, 2025
cc71a24
update execa import
alkatrivedi Apr 14, 2025
deeba17
downgrade execa and p-limit package to support the tests run against …
alkatrivedi Apr 14, 2025
6a29c02
downgrade uuid version
alkatrivedi Apr 14, 2025
744c621
update system-test-against-emulator.yaml
alkatrivedi Apr 14, 2025
af17582
add system-test-multiplexed-session.cfg in node18
alkatrivedi Apr 14, 2025
4a2e17d
update image and digest in owlbot yaml
alkatrivedi Apr 15, 2025
3c2ca74
downgrade execa and p-limit
alkatrivedi Apr 15, 2025
d7afebb
fix: presubmit error for tests
alkatrivedi Apr 15, 2025
26a3098
update coverage to node 18 version
alkatrivedi Apr 15, 2025
558169b
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Apr 15, 2025
6ed34ba
update samples-test.sh
alkatrivedi Apr 15, 2025
096f2ad
update sha and workflows
alkatrivedi Apr 15, 2025
b2b997d
Merge branch 'main' into migrate-to-node-18
alkatrivedi Apr 15, 2025
a96b0c6
Merge branch 'main' into migrate-to-node-18
alkatrivedi Apr 15, 2025
1314c2c
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Apr 15, 2025
5a925cc
Merge branch 'main' into migrate-to-node-18
alkatrivedi Apr 16, 2025
dadde43
presubmit fix
alkatrivedi Apr 16, 2025
4264975
Merge branch 'main' into migrate-to-node-18
alkatrivedi Apr 16, 2025
c241187
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Apr 16, 2025
620d359
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Apr 16, 2025
de83876
Merge branch 'migrate-to-node-18' of https://github.com/googleapis/no…
gcf-owl-bot[bot] Apr 16, 2025
0e02aa4
refactor transaction and session-pool src
alkatrivedi Apr 17, 2025
13a8c7b
Merge branch 'main' into migrate-to-node-18
alkatrivedi Apr 18, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/sync-repo-settings.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ branchProtectionRules:
- "ci/kokoro: System test"
- lint
- test (18)
- test (20)
- test (22)
- cla/google
- windows
- OwlBot Post Processor
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [14, 16, 18]
node: [18, 20, 22]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/system-tests-against-emulator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
- uses: actions/setup-node@v4
with:
node-version: 14
node-version: 18
- run: node --version
- run: npm install
- run: npm run system-test
Expand Down
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,3 @@ system-test/*key.json
.DS_Store
package-lock.json
__pycache__
.idea
24 changes: 0 additions & 24 deletions .kokoro/continuous/node14/common.cfg

This file was deleted.

4 changes: 0 additions & 4 deletions .kokoro/continuous/node14/lint.cfg

This file was deleted.

12 changes: 0 additions & 12 deletions .kokoro/continuous/node14/samples-test.cfg

This file was deleted.

12 changes: 0 additions & 12 deletions .kokoro/continuous/node14/system-test.cfg

This file was deleted.

Empty file.
24 changes: 0 additions & 24 deletions .kokoro/presubmit/node14/common.cfg

This file was deleted.

12 changes: 0 additions & 12 deletions .kokoro/presubmit/node14/samples-test.cfg

This file was deleted.

12 changes: 0 additions & 12 deletions .kokoro/presubmit/node14/system-test.cfg

This file was deleted.

Empty file.
6 changes: 4 additions & 2 deletions .kokoro/samples-test.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions OBSERVABILITY.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,10 @@ const {
const exporter = new TraceExporter();

// Create the tracerProvider that the exporter shall be attached to.
const provider = new NodeTracerProvider({resource: resource});
provider.addSpanProcessor(new BatchSpanProcessor(exporter));
const provider = new NodeTracerProvider({
resource: resource,
spanProcessors: [new BatchSpanProcessor(exporter)]
});

// Create the Cloud Spanner Client.
const {Spanner} = require('@google-cloud/spanner');
Expand Down
6 changes: 3 additions & 3 deletions benchmark/benchmarking-multiplexed-session.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ async function main(
method,
multiplexedEnabled,
numThreads,
numQueries
numQueries,
) {
// enable the env variable
multiplexedEnabled === 'true'
Expand Down Expand Up @@ -70,7 +70,7 @@ async function main(

// push the time taken by thread to the array
thread_execution_times.push(
(performance.now() - startThreadTime).toFixed(2)
(performance.now() - startThreadTime).toFixed(2),
);
}

Expand All @@ -94,7 +94,7 @@ async function main(

// push the time taken by thread to the array
thread_execution_times.push(
(performance.now() - startThreadTime).toFixed(2)
(performance.now() - startThreadTime).toFixed(2),
);
}

Expand Down
Loading
Loading