fix: Logic for retrying specifiied internal errors #1822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olavloite
approved these changes
Mar 14, 2023
Contributor
olavloite
left a comment
There was a problem hiding this comment.
LGTM, but with a small nit/question on why we are not using the generic method for the streaming function.
asthamohta
approved these changes
Mar 17, 2023
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Apr 6, 2023
🤖 I have created a release *beep* *boop* --- ## [6.8.0](https://togithub.com/googleapis/nodejs-spanner/compare/v6.7.2...v6.8.0) (2023-04-06) ### Features * Adding new fields for Serverless analytics ([#1816](https://togithub.com/googleapis/nodejs-spanner/issues/1816)) ([2a6ca6f](https://togithub.com/googleapis/nodejs-spanner/commit/2a6ca6f09215752f9451d625ac02837e9d70b66a)) ### Bug Fixes * Begin transaction foes not handle error ([#1833](https://togithub.com/googleapis/nodejs-spanner/issues/1833)) ([6ecd366](https://togithub.com/googleapis/nodejs-spanner/commit/6ecd366da7183d502c710cb5c879984c276b12db)) * Correcting the proto field Id for field data_boost_enabled ([#1827](https://togithub.com/googleapis/nodejs-spanner/issues/1827)) ([7f6d4cc](https://togithub.com/googleapis/nodejs-spanner/commit/7f6d4ccce9269197312f2d795ef854e1789e8fce)) * Logic for retrying specifiied internal errors ([#1822](https://togithub.com/googleapis/nodejs-spanner/issues/1822)) ([f915bd1](https://togithub.com/googleapis/nodejs-spanner/commit/f915bd16cf7e817243e46a319b3e6f270b24bf68)), closes [#1808](https://togithub.com/googleapis/nodejs-spanner/issues/1808) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1808