feat: Record READ_ROW metrics for single row calls #1612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutianf
reviewed
Jun 2, 2025
src/tabular-api-surface.ts
Outdated
|
|
||
| makeNewRequest(); | ||
| return userStream; | ||
| return createReadStreamInternal(this, true, opts); |
There was a problem hiding this comment.
why is this true? I think createReadStream is for scan not reading a single row?
There was a problem hiding this comment.
Yes. This should be false. I did this in a hurry so we should add some tests to check this.
Also pull check into a separate fn
|
@mutianf Thanks for the reviews. The main purpose of this PR was to provide reviews for one particular change in isolation and get some eyes on it before applying it to all the readRows work. Now that we agree the changes are directionally correct, I think its fine if we merge this into the ReadRows branch and continue review on this code there to unblock progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mattie pointed out an important requirement here which needs this change in place. This PR ensures the right client side metrics are collected for the right methods.
Impact
User calls with
row.getwill now write client side metrics forREAD_ROWinstead ofREAD_ROWSas required. This change ensures the right metrics are collected for the right methods.Testing
Additional Information