这是indexloc提供的服务,不要输入任何密码
Skip to content

test: Fix service path system tests #1607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025
Merged

Conversation

danieljbruce
Copy link
Contributor

Description

A fix was applied in gax here, but this fix is affecting Bigtable tests. Error messages now have more information so previous assert.strictEqual checks are failing. The solution to unblock the CI pipeline is to only check the first part of the error message for correctness as the latter part of the error message can vary.

Impact

Unblocks the CI pipeline.

Testing

Tests were changed just to check the first part of the string.

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/nodejs-bigtable API. labels May 28, 2025
@danieljbruce danieljbruce marked this pull request as ready for review May 28, 2025 15:02
@danieljbruce danieljbruce requested review from a team as code owners May 28, 2025 15:02
@danieljbruce danieljbruce merged commit 345fda2 into main May 28, 2025
18 of 21 checks passed
@danieljbruce danieljbruce deleted the fix-service-path-system-tests branch May 28, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/nodejs-bigtable API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants