这是indexloc提供的服务,不要输入任何密码
Skip to content

deps: manage hermetic_library_generation action version via Hermetic Build only #3170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025

Conversation

diegomarquezp
Copy link
Contributor

The fix googleapis/sdk-platform-java#3800 was meant for GraalVM image versions.

The regression in #3169, however, affects the hermetic_library_generation GH action instead, which is not in the sdk-platform-java template, but java-storage does not consume the renovate.json template as per its owlbot.py.

This PR removes the action yaml from renovate.json, so it's only managed by Hermetic Build

…Build only

The fix googleapis/sdk-platform-java#3800 was meant for GraalVM image versions.
The regression in #3169, however, affects the hermetic_library_generation GH action instead, which is not in the sdk-platform-java template, but java-storage does not consume the renovate.json template as per its owlbot.py.
@diegomarquezp diegomarquezp requested review from a team as code owners June 25, 2025 18:29
Copy link

Warning: This pull request is touching the following templated files:

  • renovate.json

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/java-storage API. labels Jun 25, 2025
@diegomarquezp diegomarquezp added the automerge Merge the pull request once unit tests and other checks pass. label Jun 25, 2025
@BenWhitehead BenWhitehead removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 25, 2025
@BenWhitehead
Copy link
Collaborator

Merge after #3169 merges

BenWhitehead added a commit that referenced this pull request Jun 25, 2025
#3169)

* chore: Update generation configuration at Wed Jun 25 15:48:09 UTC 2025

* chore: generate libraries at Wed Jun 25 15:48:39 UTC 2025

* chore(deps(storagecontrol)): add com.google.api:gax-httpjson

test(deps): add com.google.api:gax:testlib
test(deps): add com.google.api:gax-httpjson:testlib

* test(deps): add com.google.http-client:google-http-client

* chore: revert unintended downgrade, fix in #3170

---------

Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
@BenWhitehead BenWhitehead merged commit 626499d into main Jun 25, 2025
26 checks passed
@BenWhitehead BenWhitehead deleted the diegomarquezp-patch-2 branch June 25, 2025 21:33
mpeddada1 added a commit to googleapis/google-cloud-java that referenced this pull request Jul 11, 2025
… Build only (#11669)

The gapic-generator-java version is currently getting downgraded in the
nightly generation PR
(#11648 (comment)).

Following googleapis/java-storage#3170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants