这是indexloc提供的服务,不要输入任何密码
Skip to content

Checkstyle shoud set either failOnViolation or failOnError to true #404

@meltsufin

Description

@meltsufin

Currently, both failOnViolation and failOnError are set (https://github.com/googleapis/java-shared-config/blob/main/pom.xml#L649,L651).

The way I am reading checkstyle documentation, they are more either/or -- either fail before logging or log and then fail: https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html.

Thanks @elefeint for pointing this out.

Metadata

Metadata

Assignees

No one assigned

    Labels

    type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions