这是indexloc提供的服务，不要输入任何密码
Skip to content

deps: Manage Opentelemetry version from Shared-Deps #1995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 6, 2025
Merged

deps: Manage Opentelemetry version from Shared-Deps #1995

merged 2 commits into from
Nov 6, 2025

Conversation

@diegomarquezp
Copy link
Contributor

@diegomarquezp diegomarquezp commented Nov 6, 2025 •
edited
Loading

Follow up from googleapis/sdk-platform-java#3979, which bumps the shared opentelemetry version.
If we were to merge the next sdk-platform-java-config without this change, we would get:

Error:  Errors: 
Error:    EnabledTraceUtilTest.globalOpenTelemetryRegistersGrpcChannelConfigurator:101 » NoClassDefFound io/opentelemetry/sdk/internal/ExceptionAttributeResolver
Error:    EnabledTraceUtilTest.openTelemetryInstanceRegistersGrpcChannelConfigurator:85 » NoClassDefFound io/opentelemetry/sdk/internal/ExceptionAttributeResolver
Error:    EnabledTraceUtilTest.usesGlobalOpenTelemetryIfOpenTelemetryInstanceNotProvided:68 » NoClassDefFound io/opentelemetry/sdk/internal/ExceptionAttributeResolver
Error:    EnabledTraceUtilTest.usesOpenTelemetryFromOptions:53 » NoClassDefFound io/opentelemetry/sdk/internal/ExceptionAttributeResolver

By removing this property and its references, all tests passed using a local snapshot of googleapis/sdk-platform-java#3979.

@diegomarquezp diegomarquezp requested review from a team as code owners November 6, 2025 16:06
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: datastore Issues related to the googleapis/java-datastore API. labels Nov 6, 2025
lqiu96
lqiu96 reviewed Nov 6, 2025
View reviewed changes
google-cloud-datastore/pom.xml Outdated
<properties>
<site.installationModule>google-cloud-datastore</site.installationModule>
<opentelemetry.version>1.42.1</opentelemetry.version>
<opentelemetry.version>1.52.0</opentelemetry.version>
Copy link
Member

@lqiu96 lqiu96 Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just remove this line? The version should be managed from shared-deps and not from within datastore itself

Copy link
Contributor Author

@diegomarquezp diegomarquezp Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point. Yes, shared-dependencies can take care of the versions.

@diegomarquezp diegomarquezp added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 6, 2025
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Nov 6, 2025
@diegomarquezp diegomarquezp changed the title deps: update opentelemetry.version to 1.52.0 deps: remove opentelemetry.version Nov 6, 2025
@diegomarquezp diegomarquezp requested a review from lqiu96 November 6, 2025 16:41
@lqiu96 lqiu96 changed the title deps: remove opentelemetry.version deps: Manage Opentelemetry version from Shared-Deps Nov 6, 2025
@diegomarquezp diegomarquezp mentioned this pull request Nov 6, 2025
Merged
@diegomarquezp diegomarquezp merged commit 5f6c500 into main Nov 6, 2025
26 checks passed
@diegomarquezp diegomarquezp deleted the deps/bump-opentelemetry branch November 6, 2025 20:13
@release-please release-please bot mentioned this pull request Nov 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lqiu96 lqiu96 lqiu96 approved these changes

Assignees

No one assigned

Labels

api: datastore Issues related to the googleapis/java-datastore API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@diegomarquezp @lqiu96 @yoshi-kokoro