fix(spanner): use fresh context for rollback #12897
Merged
+46
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a fresh context without a timeout for the Rollback call when a transaction has failed. This prevents the Rollback from being skipped or cancelled if the original context's deadline has been exceeded. This again would lead to the locks that had been taken by the transaction to remain in place until Spanner releases these after 10 seconds.
rahul2393
approved these changes
Sep 17, 2025
rahul2393
pushed a commit
that referenced
this pull request
Sep 29, 2025
🤖 I have created a release *beep* *boop* --- ## [1.86.0](spanner/v1.85.1...spanner/v1.86.0) (2025-09-26) ### Features * **spanner:** Support "readOnly" column tag parsing for Go struct operations ([#12895](#12895)) ([003abca](003abca)) ### Bug Fixes * **spanner:** Use fresh context for rollback ([#12897](#12897)) ([99c7eeb](99c7eeb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a fresh context without a timeout for the Rollback call when a transaction has failed. This prevents the Rollback from being skipped or cancelled if the original context's deadline has been exceeded. This again would lead to the locks that had been taken by the transaction to remain in place until Spanner releases these after 10 seconds.