这是indexloc提供的服务,不要输入任何密码
Skip to content

feat(spanner/spansql): add support for EXISTS subquery #12439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion spanner/spansql/parser.go
Original file line number Diff line number Diff line change
Expand Up @@ -4310,6 +4310,7 @@ ascending order of precedence:
parseExpr
orParser
andParser
parseExistsOp
parseIsOp
parseInOp
parseComparisonOp
Expand Down Expand Up @@ -4418,7 +4419,7 @@ func newBinArithParser(opStr string, op ArithOperator, nextPrec func(*parser) (E

func (p *parser) parseLogicalNot() (Expr, *parseError) {
if !p.eat("NOT") {
return p.parseIsOp()
return p.parseExistsOp()
}
be, err := p.parseBoolExpr()
if err != nil {
Expand All @@ -4427,6 +4428,27 @@ func (p *parser) parseLogicalNot() (Expr, *parseError) {
return LogicalOp{Op: Not, RHS: be}, nil
}

func (p *parser) parseExistsOp() (Expr, *parseError) {
debugf("parseExistsOp: %v", p)

if !p.eat("EXISTS") {
return p.parseIsOp()
}

if err := p.expect("("); err != nil {
return nil, err
}
subq, err := p.parseQuery()
if err != nil {
return nil, err
}
if err := p.expect(")"); err != nil {
return nil, err
}

return ExistsOp{Subquery: subq}, nil
}

func (p *parser) parseIsOp() (Expr, *parseError) {
debugf("parseIsOp: %v", p)

Expand Down
25 changes: 25 additions & 0 deletions spanner/spansql/parser_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,31 @@ func TestParseQuery(t *testing.T) {
},
},
},
{
`SELECT * FROM A WHERE EXISTS (SELECT * FROM B)`,
Query{
Select: Select{
List: []Expr{Star},
From: []SelectFrom{
SelectFromTable{
Table: "A",
},
},
Where: ExistsOp{
Subquery: Query{
Select: Select{
List: []Expr{Star},
From: []SelectFrom{
SelectFromTable{
Table: "B",
},
},
},
},
},
},
},
},
}
for _, test := range tests {
got, err := ParseQuery(test.in)
Expand Down
7 changes: 7 additions & 0 deletions spanner/spansql/sql.go
Original file line number Diff line number Diff line change
Expand Up @@ -1048,6 +1048,13 @@ func (co ComparisonOp) addSQL(sb *strings.Builder) {
}
}

func (eo ExistsOp) SQL() string { return buildSQL(eo) }
func (eo ExistsOp) addSQL(sb *strings.Builder) {
sb.WriteString("EXISTS (")
eo.Subquery.addSQL(sb)
sb.WriteString(")")
}

func (io InOp) SQL() string { return buildSQL(io) }
func (io InOp) addSQL(sb *strings.Builder) {
io.LHS.addSQL(sb)
Expand Down
29 changes: 29 additions & 0 deletions spanner/spansql/sql_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1216,6 +1216,35 @@ func TestSQL(t *testing.T) {
`SELECT A, B AS banana FROM Table WHERE C < "whelp" AND D IS NOT NULL ORDER BY OCol DESC LIMIT 1000`,
reparseQuery,
},
{
Query{
Select: Select{
List: []Expr{Star},
From: []SelectFrom{
SelectFromTable{
Table: "A",
},
},
Where: LogicalOp{
Op: Not,
RHS: ExistsOp{
Subquery: Query{
Select: Select{
List: []Expr{Star},
From: []SelectFrom{
SelectFromTable{
Table: "B",
},
},
},
},
},
},
},
},
`SELECT * FROM A WHERE NOT EXISTS (SELECT * FROM B)`,
reparseQuery,
},
{
Query{
Select: Select{
Expand Down
7 changes: 7 additions & 0 deletions spanner/spansql/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -808,6 +808,13 @@ const (
NotBetween
)

type ExistsOp struct {
Subquery Query
}

func (ExistsOp) isBoolExpr() {} // usually
func (ExistsOp) isExpr() {}

type InOp struct {
LHS Expr
Neg bool
Expand Down
Loading