pkg/gcs: check errors with errors.Is #5996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After googleapis/google-cloud-go#11519, the cloud storage library wraps the errors which we used to check directly. This has led to multiple asset upload errors.
tarasmadan
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After googleapis/google-cloud-go#11519, the cloud storage library wraps the errors which we used to check directly. This has led to multiple asset upload errors.
We need this PR ASAP to fix asset storage, but then it would be nice to think how we could have caught such an incompatibility. In
syz-cluster, I was using https://github.com/fsouza/fake-gcs-server in the dev environment, probably we could add it to ourenvcontainer and write some tests forpkg/gcsagainst the emulated server?