fix link to AMD docs #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@deeglaze why did you close the PR? Is the link working for you, or anything missing for it to be merged? |
Contributor
|
Sorry, I must have closed this in my sleep. There's another wp-content link in verify/trust/trust.go that should be fixed as well. Would you change that one too, please? |
Signed-off-by: Fabian Kammel <fabian.kammel@control-plane.io>
928d308 to
578613f
Compare
Contributor
Author
|
PTAL @deeglaze |
Contributor
|
It is not the same. The contents are in the SEV ABI format for public keys. The link is also broken in AMD's repo, which I propose a fix here: https://github.com/AMDESE/sev-guest/pull/42/files |
Signed-off-by: Fabian Kammel <fabian@kammel.dev>
deeglaze
approved these changes
Aug 10, 2023
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link has changed