Use pre-generated local private keys for default AMD keys #130
+295
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3a2add9 to
0502bca
Compare
Contributor
|
Have you verified that these changes stop your test from crashing? |
deeglaze
reviewed
Jul 18, 2024
0502bca to
25b5404
Compare
Collaborator
Author
Though those changes cannot stop my test from crashing, it might be a good practice to use the pre-generated test private keys to make tests run faster. |
deeglaze
reviewed
Jul 23, 2024
deeglaze
approved these changes
Jul 23, 2024
25b5404 to
e8d0943
Compare
Collaborator
Author
|
ooops looks like the PR merging policy is a bit different from go-tpm-tools, sending 1 reapproval request to @deeglaze |
deeglaze
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load local ECDSA private keys instead of using
ecdsa.GenerateKeybecause the underlying implementations will cause our internal test environment crash.