-
Notifications
You must be signed in to change notification settings - Fork 79
feat: Update network field to use caip2 schema BREAKING CHANGE #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jsutaria
wants to merge
4
commits into
google-agentic-commerce:main
Choose a base branch
from
jsutaria:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7cea318
feat: Update network field to use CAIP-2 format instead of plain strings
jsutaria c7ddf88
docs: Clarify CAIP-2 network format with multi-chain examples
madeleine-c 4416d0c
remove non caip2 chains
madeleine-c 473e3a0
style: Revert automatic formatting changes in markdown files
madeleine-c File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -142,7 +142,7 @@ class x402ServerConfig(BaseModel): | |||||
| """Configuration for how a server expects to be paid""" | ||||||
| price: Union[str, int, TokenAmount] # Payment price (Money or TokenAmount) | ||||||
| pay_to_address: str # Ethereum address to receive payment | ||||||
| network: str = "base" # Blockchain network | ||||||
| network: str = "eip155:8453" # Blockchain network (CAIP-2 format, Base mainnet) | ||||||
| description: str = "Payment required..." # Human-readable description | ||||||
| mime_type: str = "application/json" # Expected response type | ||||||
| max_timeout_seconds: int = 600 # Payment validity timeout | ||||||
|
|
@@ -383,7 +383,7 @@ def create_payment_requirements( | |||||
| price: Union[str, int, TokenAmount], # Price can be Money or TokenAmount | ||||||
| pay_to_address: str, | ||||||
| resource: str, | ||||||
| network: str = "base", | ||||||
| network: str = "eip155:8453", | ||||||
| description: str = "", | ||||||
| mime_type: str = "application/json", | ||||||
| scheme: str = "exact", | ||||||
|
|
@@ -808,7 +808,7 @@ async def handle_payment_request(task: Task, price: str, resource: str): | |||||
| price=price, # Can be "$1.00", 1.00, or TokenAmount | ||||||
| pay_to_address="0x...", # Merchant's address | ||||||
| resource=resource, | ||||||
| network="base", | ||||||
| network="eip155:8453", | ||||||
| description="Service payment" | ||||||
| ) | ||||||
|
|
||||||
|
|
@@ -837,7 +837,7 @@ async def handle_payment_submission(task: Task, payment_requirements: PaymentReq | |||||
| if not verify_response.is_valid: | ||||||
| task = utils.record_payment_failure( | ||||||
| task, "verification_failed", | ||||||
| SettleResponse(success=False, network="base", error_reason=verify_response.invalid_reason) | ||||||
| SettleResponse(success=False, network="eip155:8453", error_reason=verify_response.invalid_reason) | ||||||
| ) | ||||||
| return task | ||||||
|
|
||||||
|
|
@@ -851,7 +851,7 @@ async def handle_payment_submission(task: Task, payment_requirements: PaymentReq | |||||
| settle_response_result = SettleResponse( | ||||||
| success=settle_response.success, | ||||||
| transaction=settle_response.transaction, | ||||||
| network=settle_response.network or "base", | ||||||
| network=settle_response.network or "eip155:8453", | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The fallback network is hardcoded to
Suggested change
|
||||||
| payer=settle_response.payer, | ||||||
| error_reason=settle_response.error_reason | ||||||
| ) | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The network is hardcoded to
"eip155:8453"(Base mainnet) in this failure case. This is incorrect if the payment was intended for a different network. You should use the network from thepayment_requirementsobject, which is available in this function's scope.